Skip to content

Conversation

@ucapbba
Copy link
Contributor

@ucapbba ucapbba commented Mar 8, 2025

raise KeyError to allow to work with ChainMap

see #247 for details on why we need to raise a KeyError

raise KeyError to allow to work with ChainMap
@ucapbba ucapbba requested a review from ntessore March 8, 2025 13:41
@ucapbba
Copy link
Contributor Author

ucapbba commented Mar 11, 2025

@ntessore #215 is in progress I propose leaving the chaining test as it is

Copy link
Contributor

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ucapbba! Two minor changes to make the style checker happy

ucapbba and others added 2 commits March 13, 2025 08:08
@ucapbba ucapbba requested a review from ntessore March 13, 2025 08:49
Copy link
Contributor

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ntessore
Copy link
Contributor

Hm, the test failure is due to parallel builds on coveralls not being set up correctly — I will fix that.

@ucapbba ucapbba merged commit 7d11acd into main Mar 13, 2025
10 checks passed
@ucapbba ucapbba deleted the 247-FitsDict-Fix branch March 13, 2025 10:10
@ntessore ntessore linked an issue Mar 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChainMap does not work with FitsDict

3 participants