-
Notifications
You must be signed in to change notification settings - Fork 1
#247 FitsDict update to work with Chain Map #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
raise KeyError to allow to work with ChainMap
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
random number dependent error fixed
ntessore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ucapbba! Two minor changes to make the style checker happy
Co-authored-by: Nicolas Tessore <[email protected]>
Co-authored-by: Nicolas Tessore <[email protected]>
ntessore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hm, the test failure is due to parallel builds on coveralls not being set up correctly — I will fix that. |
3e489b5 to
dd78c89
Compare
dd78c89 to
42e8be7
Compare
raise KeyError to allow to work with ChainMap
see #247 for details on why we need to raise a KeyError