Skip to content

Fix pretty subtle "bug" #110 in fmod#113

Merged
pavpanchekha merged 3 commits intomainfrom
fix-110
Apr 15, 2025
Merged

Fix pretty subtle "bug" #110 in fmod#113
pavpanchekha merged 3 commits intomainfrom
fix-110

Conversation

@pavpanchekha
Copy link
Contributor

Basically, the fmod code sometimes involves calling fabs and it also sometimes depends on the precision of its arguments for intermediate computations. But it turns out that fabs sometimes returns 0 (for intervals that cross 0) and this 0 is the wrong precision (too high), which breaks refinement. The solution is to make a 0 of the correct precision.

@pavpanchekha pavpanchekha merged commit a0cda9e into main Apr 15, 2025
1 check passed
@pavpanchekha pavpanchekha deleted the fix-110 branch April 15, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant