Open
Conversation
30d7bab to
a7fdb0e
Compare
Contributor
Author
|
So—the issue with this PR, the reason I don't quite just want to merge it, is that it doesn't take into account the double-rounding machinery, which turns out to have a pretty big impact on things. Correspondingly I'm not sure if there's a bug of some kind or something, because that should actually only come up pretty rarely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had this idea for a while—we should use binary search to compute an optimal precision allocation that we can compare Rival to. That code is in this PR; it's AI-written but I did manually refactor everything. There's also an
infra/optimize.rktscript that does the optimal precision allocation for every single point in thepoints.jsonfile, in an attempt to find the ones that can be improved.So far, looking at the results, I've learned:
Excited to see what else happens!