[herd] New implementation of solve-regs#1694
Closed
HadrienRenaud wants to merge 2 commits intoherd:masterfrom
Closed
[herd] New implementation of solve-regs#1694HadrienRenaud wants to merge 2 commits intoherd:masterfrom
HadrienRenaud wants to merge 2 commits intoherd:masterfrom
Conversation
This was referenced Feb 3, 2026
Collaborator
Author
|
Supplemented by #1704: main reason is that this PR is too brittle and the assumptions are too strong. |
HadrienRenaud
added a commit
that referenced
this pull request
Feb 12, 2026
[herd] Improve implementation of solve-reg This PR proposes a series of refactos to the algorithm constructing the read-from map in registers. The main performance gains are won in the first commit by using a forgotten memoisation. The following commits improve readability and bring slightly better performances. This is a re-implementation of #1694, following feedback from @maranget. In short, the implementation in #1694, while faster, is too brittle and relies on too strong assumptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a new way to compute read-from maps in registers.
Assumptions
po | iico_data | iico_ctrlCommits
Performance
Comparing the output of
make build && time make test-asl-vmsa test-aarch64-asl cata-test-aslon master, new-transitive-closure (#1690), current and current rebased on top of new-transitive-closure, we have:master410.46s user 10.51s system 680% cpu 1:01.88 totalnew-solve-regs370.98s user 9.63s system 694% cpu 54.822 totalnew-transitive-closure193.03s user 7.33s system 654% cpu 30.601 totalnew-solve-regs+new-transitive-closure155.14s user 8.13s system 741% cpu 22.023 total