C hashtable code no longer inlined and static#1746
Open
z5146542 wants to merge 66 commits intoherd:masterfrom
Open
C hashtable code no longer inlined and static#1746z5146542 wants to merge 66 commits intoherd:masterfrom
z5146542 wants to merge 66 commits intoherd:masterfrom
Conversation
remove the template file for now litmus now isolates shared files to a shared library directory platform_io source and header is now also copied to shared library platform_io copy works correctly now progress on inline porting removed duplicate copy methods and fixed aarch64 std mode makefile config fixed x86_64 makefile config fixed confs isolated inlined barrier code fixed makefile config fixed issue with makefile on shell mode isoated all inlined files reverted changes relating to isolating config some minor changes some minor changes
added missing header
fixed kvm self mode compilation error added missing header added missing header
fixed kvm self mode compilation error added missing header added missing header
added 7 commits
March 19, 2026 16:55
potential fix to instruction port problem fixed aarch64 std and presi instruction.h error fixed kvm self mode compilation error added missing header fixed kvm self mode compilation error kvm-self.h fixed self.h dependency issue added kvm headers for fix fixed header issue getret added kvm-self.h fixed self.h dependency issue getret added
remove the template file for now litmus now isolates shared files to a shared library directory platform_io source and header is now also copied to shared library platform_io copy works correctly now progress on inline porting removed duplicate copy methods and fixed aarch64 std mode makefile config fixed x86_64 makefile config fixed confs isolated inlined barrier code fixed makefile config fixed issue with makefile on shell mode isoated all inlined files reverted changes relating to isolating config some minor changes some minor changes
potential fix to instruction port problem fixed aarch64 std and presi instruction.h error fixed kvm self mode compilation error added missing header fixed kvm self mode compilation error kvm-self.h fixed self.h dependency issue added kvm headers for fix fixed header issue getret added kvm-self.h fixed self.h dependency issue getret added
…d readability of some code
remove the template file for now litmus now isolates shared files to a shared library directory platform_io source and header is now also copied to shared library platform_io copy works correctly now progress on inline porting removed duplicate copy methods and fixed aarch64 std mode makefile config fixed x86_64 makefile config fixed confs isolated inlined barrier code fixed makefile config fixed issue with makefile on shell mode isoated all inlined files reverted changes relating to isolating config some minor changes some minor changes
potential fix to instruction port problem fixed aarch64 std and presi instruction.h error fixed kvm self mode compilation error added missing header fixed kvm self mode compilation error kvm-self.h fixed self.h dependency issue added kvm headers for fix fixed header issue getret added kvm-self.h fixed self.h dependency issue getret added
…d readability of some code
remove the template file for now litmus now isolates shared files to a shared library directory platform_io source and header is now also copied to shared library platform_io copy works correctly now progress on inline porting removed duplicate copy methods and fixed aarch64 std mode makefile config fixed x86_64 makefile config fixed confs isolated inlined barrier code fixed makefile config fixed issue with makefile on shell mode isoated all inlined files reverted changes relating to isolating config some minor changes some minor changes
potential fix to instruction port problem fixed aarch64 std and presi instruction.h error fixed kvm self mode compilation error added missing header fixed kvm self mode compilation error kvm-self.h fixed self.h dependency issue added kvm headers for fix fixed header issue getret added kvm-self.h fixed self.h dependency issue getret added
…d readability of some code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is a continuation of PR #1739 (comment)
The hashtable C implementation, previously in
/litmus/libdir/_hash.h, is now no longer inlined, and the relevant functiosn are now made non-static. This should solve the issue mentioned in #1693 (comment).