Skip to content

[catalogue] Fix AArch64 ifetch typing and VMSA fault-handler expectations#1762

Open
relokin wants to merge 3 commits intoherd:masterfrom
relokin:catalogue-fixes2
Open

[catalogue] Fix AArch64 ifetch typing and VMSA fault-handler expectations#1762
relokin wants to merge 3 commits intoherd:masterfrom
relokin:catalogue-fixes2

Conversation

@relokin
Copy link
Copy Markdown
Member

@relokin relokin commented Mar 25, 2026

Summary

This PR fixes a set of issues in the AArch64 catalogue tests:

  • fix register size mismatches in aarch64-ifetch WRC tests
  • add explicit types for registers that hold labels in aarch64-ifetch tests
  • stop checking for faults in aarch64-VMSA tests when a fault handler is present

Scope

The changes are limited to catalogue litmus tests:

  • catalogue/aarch64-ifetch/tests/...
  • catalogue/aarch64-VMSA/tests/...

Notes

This PR folds together:

  • [catalogue] Fix register size mismatch for aarch64-ifetch WRC tests
  • [catalogue] Add types for registers that hold labels for aarch64-ifetch tests
  • [catalogue] Don't check for faults when there is a fault handler for aarch64-VMSA tests

relokin added 3 commits March 25, 2026 10:25
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
…ch tests

Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
…aarch64-VMSA tests

Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
@relokin relokin marked this pull request as ready for review March 27, 2026 16:18
@relokin
Copy link
Copy Markdown
Member Author

relokin commented Mar 27, 2026

@maranget I know you are busy so this is not urgent but I'd welcome your opinion on the general direction of this patch.

We have many tests in the catalogue that trigger warnings in litmus7. I find that very noisy when I run the regressions and I am worried that, as a result, people are not even looking at the output when they run a command just as make litmus-aarch64-test. In fact some of these existing warnings are not benign at all. On the other hand, if we fix them we have to override the hash of some tests and that inhibits other protections that you have a lot more experience with than I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant