[catalogue] Fix AArch64 ifetch typing and VMSA fault-handler expectations#1762
Open
relokin wants to merge 3 commits intoherd:masterfrom
Open
[catalogue] Fix AArch64 ifetch typing and VMSA fault-handler expectations#1762relokin wants to merge 3 commits intoherd:masterfrom
relokin wants to merge 3 commits intoherd:masterfrom
Conversation
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
…ch tests Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
…aarch64-VMSA tests Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Member
Author
|
@maranget I know you are busy so this is not urgent but I'd welcome your opinion on the general direction of this patch. We have many tests in the catalogue that trigger warnings in litmus7. I find that very noisy when I run the regressions and I am worried that, as a result, people are not even looking at the output when they run a command just as make litmus-aarch64-test. In fact some of these existing warnings are not benign at all. On the other hand, if we fix them we have to override the hash of some tests and that inhibits other protections that you have a lot more experience with than I do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a set of issues in the AArch64 catalogue tests:
Scope
The changes are limited to catalogue litmus tests:
catalogue/aarch64-ifetch/tests/...catalogue/aarch64-VMSA/tests/...Notes
This PR folds together:
[catalogue] Fix register size mismatch for aarch64-ifetch WRC tests[catalogue] Add types for registers that hold labels for aarch64-ifetch tests[catalogue] Don't check for faults when there is a fault handler for aarch64-VMSA tests