CASL-592 Extension Cleanup Capability by rlakde · Pull Request #374 · heremaps/naksha

rlakde · 2024-10-30T19:18:30Z

No description provided.

Signed-off-by: lakde <rohit.lakde@here.com>

* Fixed array patching (#365) * Fixed array patching * corrected patcher test expectation * Fix thread stuck issue + addtnl logs (#368) * Added logs to troubleshoot thread hanging issue * CASL-258 unreleased lock fix (#358) * Fixed array patching (#365) (#367) * corrected patcher test expectation * updated version * updated changelog --------- Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com> --------- Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com> Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com>

github-actions · 2024-10-30T19:22:48Z

Code Coverage

Overall Project	42.68% `-0.3%`	🍏
Files changed	31.9%	🍏

Module	Coverage
here-naksha-lib-ext-manager	72.1% `-9.49%`	🍏
here-naksha-lib-core	32.8% `-0.02%`	🍏
here-naksha-lib-hub	25.01% `-5.8%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ExtensionCache.java	74.3% `-14.96%`	🍏
	AmazonS3Helper.java	59.57%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.64%`	🍏

here-naksha-lib-core/src/main/java/com/here/naksha/lib/core/IExtensionInit.java

here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java

here-naksha-lib-hub/src/main/java/com/here/naksha/lib/hub/NakshaHub.java

github-actions · 2024-11-04T18:38:52Z

Code Coverage

Overall Project	42.65% `-0.33%`	🍏
Files changed	30.08%	🍏

Module	Coverage
here-naksha-lib-ext-manager	70.45% `-11.56%`	🍏
here-naksha-lib-core	32.8% `-0.02%`	🍏
here-naksha-lib-hub	25.01% `-5.8%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ExtensionCache.java	74.3% `-14.96%`	🍏
	AmazonS3Helper.java	59.57%	🍏
	ValueTuple.java	0%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.64%`	🍏

github-actions · 2024-11-04T18:58:49Z

Code Coverage

Overall Project	42.68% `-0.28%`	🍏
Files changed	38.4%	🍏

Module	Coverage
here-naksha-lib-ext-manager	73.99% `-7.25%`	🍏
here-naksha-lib-core	32.81% `-0.02%`	🍏
here-naksha-lib-hub	25.01% `-5.8%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	76.54% `-12.12%`	🍏
	AmazonS3Helper.java	59.57%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.64%`	🍏

github-actions · 2024-11-04T19:05:35Z

Code Coverage

Overall Project	42.68% `-0.28%`	🍏
Files changed	38.29%	🍏

Module	Coverage
here-naksha-lib-ext-manager	73.99% `-7.25%`	🍏
here-naksha-lib-core	32.81% `-0.02%`	🍏
here-naksha-lib-hub	25% `-5.83%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	76.54% `-12.12%`	🍏
	AmazonS3Helper.java	59.57%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.75%`	🍏

here-naksha-lib-core/src/main/java/com/here/naksha/lib/core/IExtensionInit.java

here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java

github-actions · 2024-11-05T01:38:21Z

Code Coverage

Overall Project	42.68% `-0.28%`	🍏
Files changed	38.29%	🍏

Module	Coverage
here-naksha-lib-ext-manager	73.99% `-7.25%`	🍏
here-naksha-lib-core	32.8% `-0.02%`	🍏
here-naksha-lib-hub	25% `-5.83%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	76.54% `-12.12%`	🍏
	AmazonS3Helper.java	59.57%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.75%`	🍏

github-actions · 2024-11-05T01:41:40Z

Code Coverage

Overall Project	42.67% `-0.25%`	🍏
Files changed	38.82%	🍏

Module	Coverage
here-naksha-lib-ext-manager	75.39% `-5.23%`	🍏
here-naksha-lib-core	32.8% `-0.02%`	🍏
here-naksha-lib-hub	25% `-5.83%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	79.07% `-8.94%`	🍏
	AmazonS3Helper.java	59.57%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.75%`	🍏

github-actions · 2024-12-12T13:35:19Z

Code Coverage

Overall Project	42.66% `-0.22%`	🍏
Files changed	22.77%	🍏

Module	Coverage
here-naksha-lib-ext-manager	73.76% `-2.6%`	🍏
here-naksha-lib-core	32.8% `-0.02%`	🍏
here-naksha-lib-hub	25.01% `-5.8%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ExtensionCache.java	81.05%	🍏
	AmazonS3Helper.java	59.57%	🍏
	ValueTuple.java	0%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.64%`	🍏

github-actions · 2024-12-12T13:36:10Z

Code Coverage

Overall Project	42.66% `-0.22%`	🍏
Files changed	22.77%	🍏

Module	Coverage
here-naksha-lib-ext-manager	73.76% `-2.6%`	🍏
here-naksha-lib-core	32.8% `-0.02%`	🍏
here-naksha-lib-hub	25.01% `-5.8%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ExtensionCache.java	81.05%	🍏
	AmazonS3Helper.java	59.57%	🍏
	ValueTuple.java	0%	🍏
here-naksha-lib-core	Extension.java	0% `-24.14%`	🍏
	ExtensionConfig.java	0% `-9.09%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-18.64%`	🍏

github-actions · 2024-12-12T13:43:06Z

Code Coverage

Overall Project	42.69% `-0.1%`	🍏
Files changed	57.39%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-lib-hub	25% `-0.57%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-1.82%`	🍏

github-actions · 2024-12-20T08:24:01Z

Code Coverage

Overall Project	42.69% `-0.1%`	🍏
Files changed	57.39%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-lib-hub	25% `-0.57%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-1.82%`	🍏

github-actions · 2024-12-20T08:25:16Z

Code Coverage

Overall Project	42.69% `-0.1%`	🍏
Files changed	57.39%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-lib-hub	25% `-0.57%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-1.82%`	🍏

github-actions · 2024-12-20T08:49:29Z

Code Coverage

Overall Project	42.67% `-0.1%`	🍏
Files changed	58.33%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-lib-core	32.79%	🍏
here-naksha-lib-hub	25% `-0.57%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-1.82%`	🍏

github-actions · 2024-12-20T08:49:47Z

Code Coverage

Overall Project	42.67% `-0.1%`	🍏
Files changed	58.33%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-lib-core	32.79%	🍏
here-naksha-lib-hub	25% `-0.57%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏
here-naksha-lib-hub	NakshaHub.java	1.43% `-1.82%`	🍏

github-actions · 2025-01-03T20:56:18Z

Code Coverage

Overall Project	42.68% `-0.12%`	🍏
Files changed	53.3%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-lib-core	32.79%	🍏
here-naksha-lib-hub	24.8% `-1.25%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏
here-naksha-lib-hub	NakshaHub.java	1.42% `-4.01%`	🍏

* Updated doc about existing JWT loading * added support for additional pub key * updated readme * Updated version to 2.2.1 * Updated doc for pvt and pub key * Added constants in NakshaHubConfig constructor * addressed review comments Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com>

github-actions · 2025-01-03T20:59:57Z

Code Coverage

Overall Project	42.67% `-0.18%`	🍏
Files changed	55.02%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.7% `-7.28%`	🍏
here-naksha-app-service	71.21% `-0.13%`	🍏
here-naksha-lib-core	32.79%	🍏
here-naksha-lib-hub	24.8% `-2.61%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	77.91% `-12.47%`	🍏
here-naksha-app-service	NakshaJwtAuthHandler.java	100%	🍏
	NakshaApp.java	63.92% `-2.23%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏
here-naksha-lib-hub	NakshaHubConfig.java	4.55% `-9.66%`	🍏
	NakshaHub.java	1.42% `-4.01%`	🍏

github-actions · 2025-01-06T00:32:56Z

Code Coverage

Overall Project	42.69% `-0.18%`	🍏
Files changed	56.7%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.91% `-7.22%`	🍏
here-naksha-app-service	71.21% `-0.13%`	🍏
here-naksha-lib-core	32.8%	🍏
here-naksha-lib-hub	24.8% `-2.61%`	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	78.23% `-12.3%`	🍏
here-naksha-app-service	NakshaJwtAuthHandler.java	100%	🍏
	NakshaApp.java	63.92% `-2.23%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏
here-naksha-lib-hub	NakshaHubConfig.java	4.55% `-9.66%`	🍏
	NakshaHub.java	1.42% `-4.01%`	🍏

github-actions · 2025-01-14T20:47:36Z

Code Coverage

Overall Project	42.69% `-0.08%`	🍏
Files changed	65.73%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.91% `-7.22%`	🍏
here-naksha-lib-core	32.79%	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	78.23% `-12.3%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏

hirenkp2000

Approving

here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java

github-actions · 2025-01-15T15:06:18Z

Code Coverage

Overall Project	42.68% `-0.08%`	🍏
Files changed	65.95%	🍏

Module	Coverage
here-naksha-lib-ext-manager	74.88% `-7.39%`	🍏
here-naksha-lib-core	32.79%	🍏

Files

Module	File	Coverage
here-naksha-lib-ext-manager	ValueTuple.java	100%	🍏
	ExtensionCache.java	78.13% `-12.52%`	🍏
here-naksha-lib-core	NakshaVersion.java	42.31%	🍏

rlakde and others added 14 commits August 19, 2024 11:38

Initial Changes.

4b77d3f

Signed-off-by: lakde <rohit.lakde@here.com>

Fix Unit Tests

ba85d9d

Signed-off-by: lakde <rohit.lakde@here.com>

Review Fixes

1befc37

Signed-off-by: lakde <rohit.lakde@here.com>

Merge branch 'v2' into CASL-321_Extn_Sub_Environments

fec7f97

Update openapi.yaml

58995d3

Update gradle.properties

7ec0f86

Update gradle.properties

acc5770

Update reusable-build-and-publish.yml

3e55ff9

Update gradle.properties

dbd6e79

Update openapi.yaml

9ea31d5

Merge branch 'v2' into CASL-321_Extn_Sub_Environments

c802b92

Add Interface IExtensionInit

0b204a5

Add instanceCache logic.

528c950

hirenkp2000 requested changes Nov 4, 2024

View reviewed changes

Create ValueTuple.java

7325ec8

rlakde added 4 commits November 4, 2024 12:43

loaderCache Changes

9443100

Correct logger messages

32c1b9e

Update IExtensionInit description

3bd4148

Fix bug

d718694

Correct logger in Hub.

f9314f6

hirenkp2000 requested changes Nov 4, 2024

View reviewed changes

Update IExtensionInit Description.

a8cfeaa

Correct removeExtensionFromCache.

f05cd53

Merge branch 'v2' into v2_CASL_592-Extension_Cleanup_Capability

e421d65

rlakde added 2 commits December 20, 2024 13:49

Update gradle.properties

1d73a38

Update openapi.yaml

9834cc1

rlakde added 2 commits December 20, 2024 14:16

Update NakshaVersion.java

807706c

Update gradle.properties

26ae812

rlakde added 3 commits January 3, 2025 14:46

Update gradle.properties

d364a21

Update NakshaVersion.java

6c461d3

Update NakshaHub.java

896c98c

Update ExtensionCache.java

7a70459

rlakde added 4 commits January 14, 2025 14:37

Update gradle.properties

7c5dbb0

Update openapi.yaml

698fc56

Update NakshaVersion.java

cbc078d

Merge branch 'v2' into v2_CASL_592-Extension_Cleanup_Capability

765d423

hirenkp2000 approved these changes Jan 15, 2025

View reviewed changes

here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Show resolved Hide resolved

here-naksha-lib-ext-manager/src/main/java/com/here/naksha/lib/extmanager/ExtensionCache.java Outdated Show resolved Hide resolved

Update logger as per review comment.

b0943f1

rlakde merged commit 968820e into v2 Jan 16, 2025
3 checks passed

rlakde deleted the v2_CASL_592-Extension_Cleanup_Capability branch January 22, 2025 17:41

Conversation

rlakde commented Oct 30, 2024

Uh oh!

github-actions bot commented Oct 30, 2024

Code Coverage

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 4, 2024

Code Coverage

Uh oh!

github-actions bot commented Nov 4, 2024

Code Coverage

Uh oh!

github-actions bot commented Nov 4, 2024

Code Coverage

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 5, 2024

Code Coverage

Uh oh!

github-actions bot commented Nov 5, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 12, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 12, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 12, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 20, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 20, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 20, 2024

Code Coverage

Uh oh!

github-actions bot commented Dec 20, 2024

Code Coverage

Uh oh!

github-actions bot commented Jan 3, 2025

Code Coverage

Uh oh!

github-actions bot commented Jan 3, 2025

Code Coverage

Uh oh!

github-actions bot commented Jan 6, 2025

Code Coverage

Uh oh!

github-actions bot commented Jan 14, 2025

Code Coverage

Uh oh!

hirenkp2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2025

Code Coverage

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects