Skip to content

Conversation

zyuiop
Copy link
Contributor

@zyuiop zyuiop commented Sep 17, 2025

While trying to understand the code of the executor a bit better, I found an old async { } block that is no longer required to be async (since fbc6044) and cleaned it out.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark Current: b933294 Previous: 40e0c6e Performance Ratio
startup_benchmark Build Time 136.25 s 136.14 s 1.00
startup_benchmark File Size 0.91 MB 0.90 MB 1.01
Startup Time - 1 core 0.95 s (±0.01 s) 0.94 s (±0.02 s) 1.01
Startup Time - 2 cores 0.95 s (±0.02 s) 0.92 s (±0.03 s) 1.03
Startup Time - 4 cores 0.95 s (±0.03 s) 0.96 s (±0.03 s) 0.99
multithreaded_benchmark Build Time 139.36 s 140.97 s 0.99
multithreaded_benchmark File Size 0.95 MB 1.01 MB 0.95
Multithreaded Pi Efficiency - 2 Threads 2.68 % (±12.86 %) 2.17 % (±10.40 %) 1.24
Multithreaded Pi Efficiency - 4 Threads 1.55 % (±7.46 %) 1.51 % (±7.26 %) 1.03
Multithreaded Pi Efficiency - 8 Threads 0.73 % (±3.51 %) 0.77 % (±3.68 %) 0.95
micro_benchmarks Build Time 171.82 s 171.42 s 1.00
micro_benchmarks File Size 0.96 MB 1.01 MB 0.95
Scheduling time - 1 thread 3.02 ticks (±14.48 ticks) 2.77 ticks (±13.29 ticks) 1.09
Scheduling time - 2 threads 1.35 ticks (±6.48 ticks) 1.75 ticks (±8.39 ticks) 0.77
Micro - Time for syscall (getpid) 0.19 ticks (±0.89 ticks) 0.12 ticks (±0.58 ticks) 1.53
Memcpy speed - (built_in) block size 4096 988.92 MByte/s (±4746.84 MByte/s) 1816.86 MByte/s (±8720.93 MByte/s) 0.54
Memcpy speed - (built_in) block size 1048576 729.05 MByte/s (±3499.43 MByte/s) 745.11 MByte/s (±3576.55 MByte/s) 0.98
Memcpy speed - (built_in) block size 16777216 213.32 MByte/s (±1023.93 MByte/s) 219.45 MByte/s (±1053.36 MByte/s) 0.97
Memset speed - (built_in) block size 4096 1304.35 MByte/s (±6260.87 MByte/s) 1875.00 MByte/s (±9000.00 MByte/s) 0.70
Memset speed - (built_in) block size 1048576 1297.90 MByte/s (±6229.92 MByte/s) 1029.20 MByte/s (±4940.18 MByte/s) 1.26
Memset speed - (built_in) block size 16777216 916.27 MByte/s (±4398.08 MByte/s) 924.64 MByte/s (±4438.25 MByte/s) 0.99
Memcpy speed - (rust) block size 4096 1333.33 MByte/s (±6400.00 MByte/s) 1411.76 MByte/s (±6776.47 MByte/s) 0.94
Memcpy speed - (rust) block size 1048576 577.76 MByte/s (±2773.24 MByte/s) 693.90 MByte/s (±3330.73 MByte/s) 0.83
Memcpy speed - (rust) block size 16777216 203.63 MByte/s (±977.44 MByte/s) 219.67 MByte/s (±1054.40 MByte/s) 0.93
Memset speed - (rust) block size 4096 1250.00 MByte/s (±6000.00 MByte/s) 1791.04 MByte/s (±8597.01 MByte/s) 0.70
Memset speed - (rust) block size 1048576 1324.24 MByte/s (±6356.35 MByte/s) 1105.00 MByte/s (±5304.01 MByte/s) 1.20
Memset speed - (rust) block size 16777216 858.68 MByte/s (±4121.67 MByte/s) 954.96 MByte/s (±4583.81 MByte/s) 0.90
alloc_benchmarks Build Time 168.31 s 157.27 s 1.07
alloc_benchmarks File Size 0.97 MB 0.97 MB 1.00
Allocations - Allocation success 2.00 % (±13.86 %) 2.00 % (±13.86 %) 1
Allocations - Deallocation success 1.40 % (±9.72 %) 1.40 % (±9.67 %) 1.01
Allocations - Pre-fail Allocations 2.00 % (±13.86 %) 2.00 % (±13.86 %) 1
Allocations - Average Allocation time 245.27 Ticks (±1699.64 Ticks) 262.62 Ticks (±1819.84 Ticks) 0.93
Allocations - Average Allocation time (no fail) 245.27 Ticks (±1699.64 Ticks) 262.62 Ticks (±1819.84 Ticks) 0.93
Allocations - Average Deallocation time 16.49 Ticks (±114.28 Ticks) 17.05 Ticks (±118.18 Ticks) 0.97
mutex_benchmark Build Time 165.23 s 159.65 s 1.03
mutex_benchmark File Size 0.96 MB 1.01 MB 0.95
Mutex Stress Test Average Time per Iteration - 1 Threads 0.34 ns (±2.36 ns) 0.36 ns (±2.49 ns) 0.94
Mutex Stress Test Average Time per Iteration - 2 Threads 0.44 ns (±3.05 ns) 0.38 ns (±2.63 ns) 1.16

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening self-assigned this Sep 17, 2025
@mkroening mkroening self-requested a review September 17, 2025 17:05
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mkroening mkroening added this pull request to the merge queue Oct 16, 2025
Merged via the queue into hermit-os:main with commit 376b966 Oct 16, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants