fix: clippy::uninlined_format_args and small refactors

[fogti]

No description provided.

[fogti]

The Benchmark CI error looks spurious to me...

026-01-14T12:06:54.3189414Z [    0.843437][0][�[32mINFO �[0m hermit    ] Hermit is running on common system!
2026-01-14T12:06:54.3190623Z [    0.850421][0][�[32mINFO �[0m hermit    ] Jumping into application
2026-01-14T12:06:54.3191398Z memory allocation of 16777216 bytes failed
2026-01-14T12:06:54.3191958Z Number of interrupts
2026-01-14T12:06:54.3192380Z [0][FPU]: 1
2026-01-14T12:06:54.3192733Z exit status -1
2026-01-14T12:06:54.3192967Z 
2026-01-14T12:06:54.3193118Z stderr:
2026-01-14T12:06:54.3194165Z qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.80000007H:EDX.invtsc [bit 8]
2026-01-14T12:06:54.3195078Z 
2026-01-14T12:06:54.3195221Z Exit code: 1
2026-01-14T12:06:54.3195441Z 
2026-01-14T12:06:54.3195700Z thread 'main' (14514) panicked at src/main.rs:368:9:
2026-01-14T12:06:54.3196341Z Command failed
2026-01-14T12:06:54.3197022Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2026-01-14T12:06:54.3219803Z ##[error]Process completed with exit code 101.

[github-actions]

Benchmark Results

Details

Benchmark	Current: c84ae20	Previous: a2d2e33	Performance Ratio
startup_benchmark Build Time	98.37 s	98.11 s	1.00 ❗
startup_benchmark File Size	0.82 MB	0.82 MB	1.00 ❗
Startup Time - 1 core	0.95 s (±0.03 s)	0.92 s (±0.04 s)	1.03
Startup Time - 2 cores	0.94 s (±0.03 s)	0.94 s (±0.04 s)	1.00
Startup Time - 4 cores	0.93 s (±0.03 s)	0.95 s (±0.02 s)	0.97
multithreaded_benchmark Build Time	95.80 s	95.65 s	1.00 ❗
multithreaded_benchmark File Size	0.96 MB	0.96 MB	1.00 ❗
Multithreaded Pi Efficiency - 2 Threads	87.62 % (±7.96 %)	88.13 % (±7.50 %)	0.99
Multithreaded Pi Efficiency - 4 Threads	44.24 % (±3.37 %)	44.56 % (±3.00 %)	0.99
Multithreaded Pi Efficiency - 8 Threads	25.01 % (±2.13 %)	25.85 % (±2.32 %)	0.97
micro_benchmarks Build Time	93.62 s	93.76 s	1.00 ❗
micro_benchmarks File Size	0.97 MB	0.97 MB	1.00 ❗
Scheduling time - 1 thread	67.14 ticks (±4.36 ticks)	65.74 ticks (±2.62 ticks)	1.02
Scheduling time - 2 threads	39.06 ticks (±7.08 ticks)	38.15 ticks (±5.63 ticks)	1.02
Micro - Time for syscall (getpid)	3.81 ticks (±0.55 ticks)	4.08 ticks (±0.61 ticks)	0.93
Memcpy speed - (built_in) block size 4096	69471.65 MByte/s (±49616.28 MByte/s)	68134.15 MByte/s (±48416.13 MByte/s)	1.02
Memcpy speed - (built_in) block size 1048576	29612.99 MByte/s (±24276.44 MByte/s)	29775.67 MByte/s (±24370.05 MByte/s)	0.99
Memcpy speed - (built_in) block size 16777216	28662.62 MByte/s (±23845.52 MByte/s)	28776.49 MByte/s (±23943.10 MByte/s)	1.00
Memset speed - (built_in) block size 4096	70063.58 MByte/s (±49970.66 MByte/s)	68991.38 MByte/s (±48991.61 MByte/s)	1.02
Memset speed - (built_in) block size 1048576	30335.20 MByte/s (±24709.99 MByte/s)	30519.68 MByte/s (±24790.56 MByte/s)	0.99
Memset speed - (built_in) block size 16777216	29445.82 MByte/s (±24293.63 MByte/s)	29560.49 MByte/s (±24386.41 MByte/s)	1.00
Memcpy speed - (rust) block size 4096	61778.06 MByte/s (±45508.74 MByte/s)	60546.35 MByte/s (±44625.78 MByte/s)	1.02
Memcpy speed - (rust) block size 1048576	29535.41 MByte/s (±24235.62 MByte/s)	29531.83 MByte/s (±24324.31 MByte/s)	1.00
Memcpy speed - (rust) block size 16777216	28569.52 MByte/s (±23762.77 MByte/s)	28814.85 MByte/s (±23984.59 MByte/s)	0.99
Memset speed - (rust) block size 4096	62908.63 MByte/s (±46272.29 MByte/s)	61592.50 MByte/s (±45338.24 MByte/s)	1.02
Memset speed - (rust) block size 1048576	30310.99 MByte/s (±24690.87 MByte/s)	30365.90 MByte/s (±24830.39 MByte/s)	1.00
Memset speed - (rust) block size 16777216	29350.48 MByte/s (±24209.66 MByte/s)	29592.77 MByte/s (±24424.37 MByte/s)	0.99
alloc_benchmarks Build Time	92.13 s	91.53 s	1.01 ❗
alloc_benchmarks File Size	0.89 MB	0.89 MB	1.00 ❗
Allocations - Allocation success	100.00 %	100.00 %	1
Allocations - Deallocation success	100.00 %	100.00 %	1
Allocations - Pre-fail Allocations	100.00 %	100.00 %	1
Allocations - Average Allocation time	6143.28 Ticks (±87.49 Ticks)	6065.83 Ticks (±70.16 Ticks)	1.01
Allocations - Average Allocation time (no fail)	6143.28 Ticks (±87.49 Ticks)	6065.83 Ticks (±70.16 Ticks)	1.01
Allocations - Average Deallocation time	765.45 Ticks (±106.16 Ticks)	757.49 Ticks (±92.33 Ticks)	1.01
mutex_benchmark Build Time	91.43 s	92.00 s	0.99 ❗
mutex_benchmark File Size	0.97 MB	0.97 MB	1.00 ❗
Mutex Stress Test Average Time per Iteration - 1 Threads	12.44 ns (±0.61 ns)	12.52 ns (±0.61 ns)	0.99
Mutex Stress Test Average Time per Iteration - 2 Threads	13.08 ns (±0.98 ns)	13.22 ns (±0.90 ns)	0.99

This comment was automatically generated by workflow using github-action-benchmark.

[mkroening]

Clippy does not seem to detect core::panic! correctly. I have filed an issue: rust-lang/rust-clippy#16411

[mkroening]

#2180 should help with catching more of these in the future.

[mkroening]

The Benchmark CI error looks spurious to me...

Yesn't. This is hermit-os/hermit-rs#873. Maybe our runners got faster again. #2179 should suffice as a workaround until the bad benchmark is fixed.

[mkroening]

Thanks for the PR! The first commit is definitely good to go!

I will split up the other one and adjust it slightly.
Our policy is that free-standing functions should not be imported, so that's good.
We usually avoid using the fully qualified path if possible, though, unless there are exceptional circumstances.

Note that it is typically not very useful to run Clippy for a target with an operating system. In this case, it turned out to be useful, though. :D