feat(isolation/filemap): Use proper tree for all file lookups#1256
Open
fogti wants to merge 2 commits intohermit-os:mainfrom
Open
feat(isolation/filemap): Use proper tree for all file lookups#1256fogti wants to merge 2 commits intohermit-os:mainfrom
fogti wants to merge 2 commits intohermit-os:mainfrom
Conversation
fogti
added
enhancement
github-actions
bot
added
the
feature/security
18 tasks
fogti
force-pushed
the
file-map-tree
branch
3 times, most recently
from
3ba863b to
6eaec42
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 78.24% 76.88% -1.36%
==========================================
Files 26 27 +1
Lines 3824 3876 +52
==========================================
- Hits 2992 2980 -12
- Misses 832 896 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
n0toose
reviewed
Feb 12, 2026
fogti
force-pushed
the
file-map-tree
branch
4 times, most recently
from
bd0c82b to
8625781
Compare
Contributor
Author
|
The only thing I still dislike a bit about this is that the interface of |
fogti
changed the title
fogti
commented
Feb 16, 2026
fogti
force-pushed
the
file-map-tree
branch
7 times, most recently
from
68cbed2 to
0448912
Compare
Contributor
Author
|
It doesn't make sense to keep this as draft, the change in |
fogti
force-pushed
the
file-map-tree
branch
14 times, most recently
from
b1af1a9 to
08693f9
Compare
fogti
changed the title
Contributor
Author
|
Split off Hermit image handling into #1282. |
This shifts usages of `CStr` and `OsStr` onto API consumers. All places where guest paths are used now use `&str`, and all places where host paths are used now use `&Path` (or the owned variants, respectively).
fogti
commented
Feb 25, 2026
| OnHost(PathBuf), | ||
|
|
||
| /// An in-memory file | ||
| #[allow(dead_code)] |
Contributor
Author
There was a problem hiding this comment.
I've got no clue why this lint triggers on MacOS, but not on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the implementation of the file map such that it uses an actual tree for file lookup instead of a hashmap of paths with backtracking. This should improve performance in case of an extremely large file map. The motivation for this is that it makes it way easier to represent virtual files in the file map, and is a prerequisite for Hermit image support.
For demo purposes (and to make it obvious how one would build on top of this later), this also adds support for inserting the content of tar files (i.e. decompressed Hermit images) to the file map tree.
Supersedes #1135.
Depends on #1271.
Blocked on hermit-os/hermit-entry#82.