Track contributions for team achievements. #137
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds contribution tracking for team achievements, allowing the system to record and display which team members contributed to achievement progress and when.
Key Changes:
- Updated team achievement method signatures to use
TeamAchievementtypes instead of genericAchievementtypes - Added new protobuf message types for team achievements with contributor tracking
- Defined
TeamAchievementContributormessage to track individual user contributions
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| teams.go | Updated interface method signatures to return team-specific achievement types |
| hiro.proto | Added new message types for team achievements with contributor tracking and updated RPC output types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| int64 start_time_sec = 22; | ||
| // The UNIX timestamp when this achievement will allow updates. This may be before its next reset. A zero means it does not end. | ||
| int64 end_time_sec = 23; |
There was a problem hiding this comment.
Line 3151 describes end_time_sec but states 'when this achievement will allow updates', which appears to be copied from the start_time_sec comment above. The comment should clarify that end_time_sec represents when the achievement stops allowing updates or when it ends.
| message TeamAchievementContributor { | ||
| // User identifier. | ||
| string user_id = 1; | ||
| // Username. | ||
| string username = 2; | ||
| // Avatar URL. | ||
| string avatar_url = 3; | ||
| // Display name. | ||
| string display_name = 4; | ||
| // The UNIX time (for gRPC clients) or ISO string (for REST clients) when the user first contributed. | ||
| int64 create_time_sec = 5; | ||
| // The UNIX time (for gRPC clients) or ISO string (for REST clients) when the user most recently updated their contribution. | ||
| int64 update_time_sec = 6; | ||
| // Count contributed by this user. | ||
| int64 count = 7; | ||
| } |
There was a problem hiding this comment.
It would be useful to have a metadata field here similar to the TeamEventLeaderboardsContributors. What do you think?
No description provided.