Skip to content

Conversation

@RicardRC
Copy link
Contributor

No description provided.

RicardRC and others added 5 commits September 16, 2025 12:17
(cherry picked from commit 7ed749e6f50fddb37d9bcf4903fbb031001a77fa)

# Conflicts:
#	interface/include/nakama-cpp/satori/SClientInterface.h
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the Satori API by adding new request structures and methods for server events, flags, experiments, and live events. The changes replace simple string vector parameters with structured request objects that include additional filtering capabilities.

  • Refactors API methods to use structured request objects instead of vector parameters
  • Adds new overloaded methods for HTTP key authentication (non-session-based API calls)
  • Introduces serverEvent and joinLiveEvent functionality with corresponding async methods

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
satori-cpp/test/main.cpp Updates test to use new SGetFlagsRequest structure instead of string vector
satori-cpp/src/SatoriRestClient.h Adds method declarations for new API endpoints and updates existing signatures
satori-cpp/src/SatoriRestClient.cpp Implements new methods and refactors existing ones to use request structures
satori-cpp/src/SatoriBaseClient.h Updates async method signatures to match new API structure
satori-cpp/src/SatoriBaseClient.cpp Updates async method implementations to use new request structures
satori-cpp/src/InternalLowLevelSatoriAPI.h Adds SInternalJoinLiveEventRequest structure declaration
satori-cpp/src/InternalLowLevelSatoriAPI.cpp Implements JSON parsing optimizations and additional field handling
satori-cpp/api/satori.proto Defines new protobuf messages and service endpoints
interface/include/nakama-cpp/satori/SClientInterface.h Updates interface to include new methods and request structures
interface/include/nakama-cpp/satori/HardcodedLowLevelSatoriAPI.h Defines new data structures for API requests and responses

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@RicardRC RicardRC merged commit 8bf541f into master Sep 19, 2025
1 of 2 checks passed
@RicardRC RicardRC deleted the satori-api-expansion branch October 16, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants