-
Notifications
You must be signed in to change notification settings - Fork 31
Satori api expansion #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satori api expansion #180
Conversation
(cherry picked from commit 7ed749e6f50fddb37d9bcf4903fbb031001a77fa) # Conflicts: # interface/include/nakama-cpp/satori/SClientInterface.h
Apply format
761bdde to
dc071b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR expands the Satori API by adding new request structures and methods for server events, flags, experiments, and live events. The changes replace simple string vector parameters with structured request objects that include additional filtering capabilities.
- Refactors API methods to use structured request objects instead of vector parameters
- Adds new overloaded methods for HTTP key authentication (non-session-based API calls)
- Introduces
serverEventandjoinLiveEventfunctionality with corresponding async methods
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| satori-cpp/test/main.cpp | Updates test to use new SGetFlagsRequest structure instead of string vector |
| satori-cpp/src/SatoriRestClient.h | Adds method declarations for new API endpoints and updates existing signatures |
| satori-cpp/src/SatoriRestClient.cpp | Implements new methods and refactors existing ones to use request structures |
| satori-cpp/src/SatoriBaseClient.h | Updates async method signatures to match new API structure |
| satori-cpp/src/SatoriBaseClient.cpp | Updates async method implementations to use new request structures |
| satori-cpp/src/InternalLowLevelSatoriAPI.h | Adds SInternalJoinLiveEventRequest structure declaration |
| satori-cpp/src/InternalLowLevelSatoriAPI.cpp | Implements JSON parsing optimizations and additional field handling |
| satori-cpp/api/satori.proto | Defines new protobuf messages and service endpoints |
| interface/include/nakama-cpp/satori/SClientInterface.h | Updates interface to include new methods and request structures |
| interface/include/nakama-cpp/satori/HardcodedLowLevelSatoriAPI.h | Defines new data structures for API requests and responses |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.