Fix WASM support in Nakama and Satori#171
Open
ilmalte wants to merge 2 commits intoheroiclabs:mainfrom
Open
Conversation
Refactor RPC payload handling and remove unused code. In details: - Updated the NakamaGrpcClient to directly use the payload without preparation (payload encoding is only needed for REST and not for gRPC). - Simplified the preparePayload function to always encode the payload as JSON. - Deleted platform-specific stub files/logic (no longer used). - Added tests (covers issue heroiclabs#167)
Add `dart.library.js_interop` conditional import to resolve the correct client implementation on WASM. WASM does not expose `dart.library.js`, so the stub (which throws UnsupportedError) was incorrectly selected. `dart.library.js` is kept as a fallback for Dart SDKs < 3.3 where `dart.library.js_interop` is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
dart.library.js_interopconditional import to resolve the correctclient implementation on WASM. WASM does not expose
dart.library.js,so the stub (which throws UnsupportedError) was incorrectly selected.
dart.library.jsis kept as a fallback for Dart SDKs < 3.3 wheredart.library.js_interopis not available.Note: this is dependent on PR #169 (changes from commit 72a3baf).
Really affected files are in commit 818046a: