Skip to content

Add runtime Satori client feature to delete identities.#2470

Open
zyro wants to merge 3 commits intomasterfrom
aim-satori-identity-delete
Open

Add runtime Satori client feature to delete identities.#2470
zyro wants to merge 3 commits intomasterfrom
aim-satori-identity-delete

Conversation

@zyro
Copy link
Member

@zyro zyro commented Feb 27, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new runtime feature to the Satori client for deleting identities and all their associated data. The implementation follows the existing Satori integration patterns and includes the necessary interface updates, runtime bindings for both Lua and JavaScript, and the core client implementation.

Changes:

  • Added IdentityDelete method to the Satori runtime interface
  • Implemented identity deletion in Lua runtime with snake_case naming (identity_delete)
  • Implemented identity deletion in JavaScript runtime with camelCase naming (identityDelete)
  • Added HTTP DELETE endpoint handler in the core Satori client
  • Updated nakama-common dependency to v1.44.3-0.20260227093501-82654fd671a4
  • Refactored HTTP status code checks from magic number 200 to http.StatusOK constant throughout the Satori client

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vendor/modules.txt Updated nakama-common module version to include IdentityDelete interface
vendor/github.com/heroiclabs/nakama-common/runtime/runtime.go Added IdentityDelete method to Satori interface
server/runtime_lua_nakama.go Added Lua binding for identity_delete function
server/runtime_javascript_nakama.go Added JavaScript binding for identityDelete function
internal/satori/satori.go Implemented IdentityDelete client method and refactored status code checks
go.sum Updated nakama-common dependency checksums
go.mod Updated nakama-common dependency version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

zyro and others added 2 commits February 27, 2026 09:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants