Add runtime Satori client feature to delete identities.#2470
Open
Add runtime Satori client feature to delete identities.#2470
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new runtime feature to the Satori client for deleting identities and all their associated data. The implementation follows the existing Satori integration patterns and includes the necessary interface updates, runtime bindings for both Lua and JavaScript, and the core client implementation.
Changes:
- Added
IdentityDeletemethod to the Satori runtime interface - Implemented identity deletion in Lua runtime with snake_case naming (
identity_delete) - Implemented identity deletion in JavaScript runtime with camelCase naming (
identityDelete) - Added HTTP DELETE endpoint handler in the core Satori client
- Updated nakama-common dependency to v1.44.3-0.20260227093501-82654fd671a4
- Refactored HTTP status code checks from magic number
200tohttp.StatusOKconstant throughout the Satori client
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/modules.txt | Updated nakama-common module version to include IdentityDelete interface |
| vendor/github.com/heroiclabs/nakama-common/runtime/runtime.go | Added IdentityDelete method to Satori interface |
| server/runtime_lua_nakama.go | Added Lua binding for identity_delete function |
| server/runtime_javascript_nakama.go | Added JavaScript binding for identityDelete function |
| internal/satori/satori.go | Implemented IdentityDelete client method and refactored status code checks |
| go.sum | Updated nakama-common dependency checksums |
| go.mod | Updated nakama-common dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sesposito
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.