Fix leaderboard/tournament hooks sometimes not firing.#2476
Open
Fix leaderboard/tournament hooks sometimes not firing.#2476
Conversation
Remove some potential race conditions that could cause reset/end hooks not to fire.
There was a problem hiding this comment.
Pull request overview
Fixes an intermittent race in LocalLeaderboardScheduler where tournament end/reset hooks can be skipped when end-active and expiry land on the same Unix second.
Changes:
- Add
scheduledEndActive/scheduledExpirytracking to avoid cancelling the “other” timer when both target the same second. - Simplify timer stopping behavior in
Pause()/Stop(). - Add an (currently skipped) auxiliary test and update the changelog entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
server/leaderboard_scheduler.go |
Avoids stopping/replacing timers when rescheduling to the same Unix second. |
server/leaderboard_scheduler_test.go |
Adds an auxiliary (skipped) test intended to reproduce the race condition. |
CHANGELOG.md |
Adds a release note about the fix. |
data/modules/tournament.lua |
Adds a trailing newline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some potential race conditions that could cause reset/end hooks not to fire.
Resolves #2429