feat: adding pg:upgrade:wait command#3273
Merged
nilamuthu merged 6 commits intopg-upgrade-enhancementsfrom Apr 9, 2025
Merged
Conversation
5eb3be6 to
6976716
Compare
91d74a4 to
1de380c
Compare
justinwilaby
suggested changes
Apr 8, 2025
Contributor
justinwilaby
left a comment
There was a problem hiding this comment.
Some very minor changes recommended. Overall, it looks good! Thank you!
fc0664b to
64e3e1b
Compare
64e3e1b to
aa01a7f
Compare
aa01a7f to
62d06f4
Compare
62d06f4 to
c9b7883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item
This PR creates the
pg:upgrade:waitcommand.Please refer to this doc for more information related to pg:upgrade:wait.
Testing
Check out this branch and run
yarn && yarn build./bin/run pg:upgrade:prepareon a Standard-Tier leader DB and thenpg:upgrade:waitto see it prepare./bin/run pg:upgrade:runon a Standard-Tier leader DB with an upgrade prepared and thenpg:upgrade:waitto see it runScreen.Recording.2025-04-08.at.10.57.36.AM.mov
./bin/run pg:upgrade:waitafter starting an upgrade on essential db./bin/run pg:upgrade:waitwith no database argumentpg:upgrade:waitwhen upgrade has been scheduled (shouldn't wait)7.
heroku help pg:upgrade:wait