Skip to content

fix: run:inside argument parsing order#3633

Merged
michaelmalave merged 2 commits intomainfrom
mm/fix/run-inside-command-order
Mar 31, 2026
Merged

fix: run:inside argument parsing order#3633
michaelmalave merged 2 commits intomainfrom
mm/fix/run-inside-command-order

Conversation

@michaelmalave
Copy link
Copy Markdown
Contributor

@michaelmalave michaelmalave commented Mar 31, 2026

Summary

This fixes run:inside argument parsing order leveraging revertSortedArgs for stable command argument ordering and adds regression tests for dyno-command mapping

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Run the following. The first run:inside should fail, the second should succeed.

heroku update --version 11.0.2
heroku ps --app test-fir-node-gs
heroku run:inside web-dyno --app test-fir-node-gs -- ls -a 
./bin/run run:inside web-dyno --app test-fir-node-gs -- ls -a 

Screenshots (if applicable)

Related Issues

GitHub issue: #3631
GUS work item: W-21817552

Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelmalave michaelmalave merged commit d46b239 into main Mar 31, 2026
18 checks passed
@michaelmalave michaelmalave deleted the mm/fix/run-inside-command-order branch March 31, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants