Skip to content

test: this fixes the mocking difference causing flappy tests and adds chore to PR release title #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelmalave merged 2 commits into from
Apr 1, 2026
Merged

test: this fixes the mocking difference causing flappy tests and adds chore to PR release title #3640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a5adf
this fixes the mocking difference causing flappy tests and adds chore…
michaelmalave Apr 1, 2026
8c70bf4
Merge remote-tracking branch 'origin' into mm/fix/diff-test-mock
michaelmalave Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/create-release-pr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ git add . -u
echo "Creating git commit and pushing to GitHub..."
git commit -m "v${PACKAGE_VERSION}"
git push origin "${BRANCH_NAME}"
gh pr create --title="release v${PACKAGE_VERSION}" --body "release v${PACKAGE_VERSION}"
gh pr create --title="chore: release v${PACKAGE_VERSION}" --body "chore: release v${PACKAGE_VERSION}"
2 changes: 1 addition & 1 deletion test/unit/commands/apps/diff.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe('apps:diff', function () {
api
.get(`/apps/${app1Name}/releases`).matchHeader('range', /version/).reply(404, {id: 'not_found', message: 'Couldn\'t find that app.'})
.get(`/apps/${app2Name}/releases`).matchHeader('range', /version/).reply(200, releasesWithSlug(slugId2))
.get(`/apps/${app2Name}/slugs/${slugId2}`).reply(200, slugBody(sameChecksum))
.get(`/apps/${app2Name}/slugs/${slugId2}`).optionally().reply(200, slugBody(sameChecksum))

const {error} = await runCommand(AppsDiff, [app1Name, app2Name])

Expand Down
Loading