Merged
Conversation
… to the title of the release PR
…Procfile fixture and tests to prevent regressions
|
Thanks for the quick turn around. Could we get a new CLI release cut this week? This is tripping our team up - and yes, we could remove the comments. But frankly, they're helpful to both newer teammates, and ourselves down the line when we're wondering "WTF is this doing here, and why like that?" 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating to ignore Procfile comment lines in local parsing, updating the local fixture to include a top comment, and add unit tests to prevent regressions while preserving existing parse-error behavior for malformed entries.
Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Add comments to a local project with a Procfile
Screenshots (if applicable)
Related Issues
GitHub issue: #3636
GUS work item: [WI number](WI link)