Skip to content

fix: procfile comment parsing#3641

Merged
michaelmalave merged 3 commits intomainfrom
mm/fix/procfile-comment-parsing
Apr 1, 2026
Merged

fix: procfile comment parsing#3641
michaelmalave merged 3 commits intomainfrom
mm/fix/procfile-comment-parsing

Conversation

@michaelmalave
Copy link
Copy Markdown
Contributor

Summary

Updating to ignore Procfile comment lines in local parsing, updating the local fixture to include a top comment, and add unit tests to prevent regressions while preserving existing parse-error behavior for malformed entries.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Notes:

Add comments to a local project with a Procfile

cd /to/local/project
/path/to/cli/bin/run local 

Screenshots (if applicable)

Related Issues

GitHub issue: #3636
GUS work item: [WI number](WI link)

@michaelmalave michaelmalave requested a review from a team as a code owner April 1, 2026 20:56
Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelmalave michaelmalave merged commit aae3751 into main Apr 1, 2026
17 checks passed
@michaelmalave michaelmalave deleted the mm/fix/procfile-comment-parsing branch April 1, 2026 21:39
@stevenharman
Copy link
Copy Markdown

Thanks for the quick turn around. Could we get a new CLI release cut this week? This is tripping our team up - and yes, we could remove the comments. But frankly, they're helpful to both newer teammates, and ourselves down the line when we're wondering "WTF is this doing here, and why like that?" 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants