Merged
Conversation
…n 404 tests to stop flaky unit failures
michaelmalave
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
michaelmalave
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
michaelmalave
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
michaelmalave
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This resolves slug checksums sequentially and drop unused app2 nock mocks in 404 tests to stop flaky unit failures.
Before the fix: 3/1000 failures that may interrupt a PR testing intermittently.
After the fix: 0/1000 failures.
Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
CI passes
Screenshots (if applicable)
Related Issues
GitHub issue: #[GitHub issue number]
GUS work item: [WI number](WI link)