Skip to content

test: use Sinon stubs; parallel slug checksums#3650

Merged
michaelmalave merged 1 commit intomainfrom
mm/fix/app-diff-flaky-unit-tests
Apr 8, 2026
Merged

test: use Sinon stubs; parallel slug checksums#3650
michaelmalave merged 1 commit intomainfrom
mm/fix/app-diff-flaky-unit-tests

Conversation

@michaelmalave
Copy link
Copy Markdown
Contributor

@michaelmalave michaelmalave commented Apr 8, 2026

Summary

This restores parallel slug checksums and replacing flaky nock HTTP mocks with Sinon stubs on APIClient.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

CI passes

@michaelmalave michaelmalave requested a review from a team as a code owner April 8, 2026 00:48
Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelmalave michaelmalave merged commit 73e4990 into main Apr 8, 2026
18 checks passed
@michaelmalave michaelmalave deleted the mm/fix/app-diff-flaky-unit-tests branch April 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants