Install bundler via gem install
#1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/gem-install-bundler
branch
5 times, most recently
from
6cd0301 to
bc21694
Compare
edmorley
approved these changes
Dec 12, 2025
schneems
force-pushed
the
schneems/gem-install-bundler
branch
2 times, most recently
from
11d9705 to
f162266
Compare
schneems
changed the base branch from
main
to
schneems/re-apply-reverted-refactor-pr
schneems
changed the title
gem installgem install
schneems
force-pushed
the
schneems/re-apply-reverted-refactor-pr
branch
7 times, most recently
from
fd234d7 to
c64cddc
Compare
Base automatically changed from
schneems/re-apply-reverted-refactor-pr
to
main
January 5, 2026 16:40
Previously we downloaded a version from S3. This moves the classic buildpack to be more like the CNB https://github.com/heroku/buildpacks-ruby/blob/8729d93fbef99696ec1f039a4accc52a2f98f3bc/buildpacks/ruby/src/layers/bundle_download_layer.rs.
This strategy can also be used in the Ruby CNB. This is needed to make this a refactor and preserve the ability to set default_config_vars before calling `bundle install` based on gems (versus after calling `bundle install` we can use `bundle list` output/parsing).
schneems
force-pushed
the
schneems/gem-install-bundler
branch
from
f162266 to
76d9df2
Compare
schneems
changed the title
gem installgem install
schneems
force-pushed
the
schneems/gem-install-bundler
branch
4 times, most recently
from
1f6b444 to
e1abf82
Compare
We know where bundler will live, we can put it in the right place from the start.
The prior directory check only looked at `vendor/bundle/#{engine}/#{major}.#{minor}.0` (which does not include the bundler version). This prevented installing/updating bundler versions. The logic now checks the specific bundler version before skipping installation.
schneems
force-pushed
the
schneems/gem-install-bundler
branch
from
e1abf82 to
45d7caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we downloaded a version from S3. This moves the classic buildpack to be more like the CNB https://github.com/heroku/buildpacks-ruby/blob/8729d93fbef99696ec1f039a4accc52a2f98f3bc/buildpacks/ruby/src/layers/bundle_download_layer.rs.
If there are no problems with this technique, we should be able to install and use arbitrary bundler versions