feat: Overwriting User-Agent on CLI requests for MCP mode#21
Merged
Conversation
justinwilaby
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here we include changes to:
HEROKU_HEADERSenv var with the required value on the spawned CLI process.HEROKU_MCP_SERVER_VERSIONthat will be used by the CLI to know the MCP server version and add it to the information sent to Backboard and Honeycomb to enable us to create metrics based on MCP server usage (see PR #3279).Testing
npm install && npm run buildnpx @modelcontextprotocol/inspector dist/index.js🔍 MCP Inspector is up and running at ...as it might be up at a different port).Add Environment Variableand add the variableDEBUGwith valuehttp,http:headers.Connectand thenList Tools. Select one of the tools likelist_appsand click Run Tool.HEROKU_HEADERSenv var like@heroku/cli-command, but that's not a problem because we will be sending the version on the payload.SOC2 Compliance
GUS Work Item: W-18205123