feat(pci): allow override of pci ids filepath#4
Conversation
|
Thanks for the PR. Does your system use I think it would make sense to hardcode and try all common paths for the pci.ids file Since this is a library, I'm not sure if doing it via environment variable makes the most sense. Maybe it would make sense to add an optional method parameter to pass a custom path, and let the consumer of the library handle edge cases. |
this makes sense to me. I went the env route since we don’t have any hooks into init(). Let me play with a few other ideas. Not married to the env idea, the var is not used anywhere else in my app that uses this library. |
currently there's no way to override this filepath if your system uses a different location for the pci ids db.