Skip to content

Conversation

@jylenhof
Copy link

No description provided.

@jylenhof jylenhof requested a review from a team as a code owner December 23, 2025 13:56
Copy link
Contributor

@phm07 phm07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution! 🙂
I added some suggestions. Maybe we could get some other opinions as well. I think adding this to the docs would make sense.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.48%. Comparing base (e01a16e) to head (800097e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
- Coverage   72.50%   67.48%   -5.03%     
==========================================
  Files         302      302              
  Lines       10995    10995              
==========================================
- Hits         7972     7420     -552     
- Misses       2150     2652     +502     
- Partials      873      923      +50     
Flag Coverage Δ
e2e ?
unit 67.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +55 to +58

> [!NOTE]
> This repository is using `mise` as explained in [CONTRIBUTING](../../CONTRIBUTING.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!NOTE]
> This repository is using `mise` as explained in [CONTRIBUTING](../../CONTRIBUTING.md)

After considering this again, this should not be here as it's not relevant for installation. Other than that, we are ready to merge 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants