Skip to content

Conversation

@xoxys
Copy link
Contributor

@xoxys xoxys commented Jan 18, 2026

Fixes: #1128

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.77%. Comparing base (93f24b6) to head (56f1e6e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   68.38%   64.77%   -3.62%     
==========================================
  Files          23       23              
  Lines        2619     2620       +1     
==========================================
- Hits         1791     1697      -94     
- Misses        654      755     +101     
+ Partials      174      168       -6     
Flag Coverage Δ
e2e ?
unit 64.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmetzner
Copy link
Contributor

I think this should be fine to accept.

There might be the edge case of someone having a Service with UDP configured, but actually running a TCP application at the specified port. If we continue here, such Services should not get cleaned up. Therefore, this is not a breaking change, if someone relies on the current behavior.

Any thoughts @apricote ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling of unsupported protocols can lead to source_port_already_used

2 participants