Skip to content

Conversation

@lukasmetzner
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.39%. Comparing base (93f24b6) to head (26080af).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/load_balancers.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   68.38%   68.39%   +0.01%     
==========================================
  Files          23       23              
  Lines        2619     2623       +4     
==========================================
+ Hits         1791     1794       +3     
- Misses        654      655       +1     
  Partials      174      174              
Flag Coverage Δ
e2e 44.04% <61.53%> (-0.08%) ⬇️
unit 64.77% <92.30%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmetzner
Copy link
Contributor Author

Previously, getProxyProtocolEnabled always returned false when the annotations was not set (#1123). So returning false is fine, when the global default is not configured.

@lukasmetzner lukasmetzner marked this pull request as ready for review January 19, 2026 12:30
@lukasmetzner lukasmetzner requested a review from a team as a code owner January 19, 2026 12:30
@lukasmetzner lukasmetzner merged commit c0c31a2 into main Jan 19, 2026
21 of 26 checks passed
@lukasmetzner lukasmetzner deleted the fix-proxy-protocol-default branch January 19, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants