Skip to content

Conversation

@jooola
Copy link
Member

@jooola jooola commented Jan 6, 2026

This error code explicitly document that the request should be retried.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.01%. Comparing base (3c5f4b1) to head (e8b4543).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   80.00%   80.01%           
=======================================
  Files          60       60           
  Lines        4492     4494    +2     
=======================================
+ Hits         3594     3596    +2     
  Misses        596      596           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola requested a review from apricote January 7, 2026 10:32
@jooola jooola marked this pull request as ready for review January 7, 2026 10:32
@jooola jooola requested a review from a team as a code owner January 7, 2026 10:32
@jooola jooola merged commit 3def8ef into main Jan 7, 2026
4 checks passed
@jooola jooola deleted the retry-on-timeout branch January 7, 2026 10:32
jooola pushed a commit that referenced this pull request Jan 8, 2026
<!-- section-start changelog -->
### `ResourceActionClient` now has a generic type parameter

The
[`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient)
struct now has a generic type parameter. The type parameter is used to
describe the API resource of the Actions client.

The
[`IResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#IResourceActionClient)
interface that is generated from the
[`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient)
struct, is also affected by this change.

This API was never intended to be used directly and we did not find any
usage of it in public code. So while potentially breaking, the benefits
of this change out weighted the risks of doing it.

### Features

- retry request on API `timeout` error (#797)
- list actions for a given resource (#791)

<!-- section-end changelog -->

---

<details>
<summary><h4>PR by <a
href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a>
🤖</h4></summary>

If you want to modify the proposed release, add you overrides here. You
can learn more about the options in the docs.

## Release Notes

### Prefix / Start

This will be added to the start of the release notes.

~~~~rp-prefix
### `ResourceActionClient` now has a generic type parameter

The
[`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient)
struct now has a generic type parameter. The type parameter is used to
describe the API resource of the Actions client.

The
[`IResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#IResourceActionClient)
interface that is generated from the
[`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient)
struct, is also affected by this change.

This API was never intended to be used directly and we did not find any
usage of it in public code. So while potentially breaking, the benefits
of this change out weighted the risks of doing it.
~~~~

### Suffix / End

This will be added to the end of the release notes.

~~~~rp-suffix
~~~~

</details>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Jan 8, 2026
…4.0 (hetznercloud/fleeting-plugin-hetzner!330)

This MR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | `v2.33.0` → `v2.34.0` | ![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fhetznercloud%2fhcloud-go%2fv2/v2.34.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fhetznercloud%2fhcloud-go%2fv2/v2.33.0/v2.34.0?slim=true) |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.34.0`](https://github.com/hetznercloud/hcloud-go/blob/HEAD/CHANGELOG.md#v2340)

[Compare Source](hetznercloud/hcloud-go@v2.33.0...v2.34.0)

##### `ResourceActionClient` now has a generic type parameter

The [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct now has a generic type parameter. The type parameter is used to describe the API resource of the Actions client.

The [`IResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#IResourceActionClient) interface that is generated from the [`ResourceActionClient`](https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud#ResourceActionClient) struct, is also affected by this change.

This API was never intended to be used directly and we did not find any usage of it in public code. So while potentially breaking, the benefits of this change out weighted the risks of doing it.

##### Features

- retry request on API `timeout` error ([#&#8203;797](hetznercloud/hcloud-go#797))
- list actions for a given resource ([#&#8203;791](hetznercloud/hcloud-go#791))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43NC4zIiwidXBkYXRlZEluVmVyIjoiNDIuNzQuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants