Skip to content

Conversation

@jooola
Copy link
Member

@jooola jooola commented Jun 25, 2025

Rename the class to fix the typo, and keep an alias for backward compatibility.

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.89%. Comparing base (47134e1) to head (eb53e79).
⚠️ Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/load_balancers/domain.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   92.95%   92.89%   -0.06%     
==========================================
  Files          64       64              
  Lines        3023     3028       +5     
==========================================
+ Hits         2810     2813       +3     
- Misses        213      215       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola merged commit 8491fea into main Jun 25, 2025
10 checks passed
@jooola jooola deleted the fix-typo branch June 25, 2025 08:33
jooola pushed a commit that referenced this pull request Jul 9, 2025
<!-- section-start changelog -->
### Bug Fixes

- typo in `LoadBalancerHealthCheckHttp` class name (#511)
- equality for some domain classes (#510)
- use valid license identifier (SPDX) (#514)

<!-- section-end changelog -->

---

<details>
<summary><h4>PR by <a
href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a>
🤖</h4></summary>

If you want to modify the proposed release, add you overrides here. You
can learn more about the options in the docs.

## Release Notes

### Prefix / Start

This will be added to the start of the release notes.

```rp-prefix
```

### Suffix / End

This will be added to the end of the release notes.

```rp-suffix
```

</details>

Co-authored-by: Hetzner Cloud Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants