Skip to content

Conversation

@jooola
Copy link
Member

@jooola jooola commented Jul 9, 2025

Fixes #513

********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:

License :: OSI Approved :: MIT License

See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************

See https://github.com/hetznercloud/hcloud-python/actions/runs/15873016015/job/44753884445#step:5:24

@jooola jooola requested a review from apricote July 9, 2025 09:32
@jooola jooola mentioned this pull request Jul 9, 2025
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.43%. Comparing base (bcbdd7d) to head (de7138d).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          64       64           
  Lines        3048     3048           
=======================================
  Hits         2848     2848           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jooola jooola merged commit a813f93 into hetznercloud:main Jul 9, 2025
10 checks passed
jooola pushed a commit that referenced this pull request Jul 9, 2025
<!-- section-start changelog -->
### Bug Fixes

- typo in `LoadBalancerHealthCheckHttp` class name (#511)
- equality for some domain classes (#510)
- use valid license identifier (SPDX) (#514)

<!-- section-end changelog -->

---

<details>
<summary><h4>PR by <a
href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a>
🤖</h4></summary>

If you want to modify the proposed release, add you overrides here. You
can learn more about the options in the docs.

## Release Notes

### Prefix / Start

This will be added to the start of the release notes.

```rp-prefix
```

### Suffix / End

This will be added to the end of the release notes.

```rp-suffix
```

</details>

Co-authored-by: Hetzner Cloud Bot <>
@jooola jooola deleted the license-id branch August 6, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setuptools warning

2 participants