refactor: use base domain parse datetime helper #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
refactor-parse-datetime
branch
from
dc3bc93 to
897803d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 96.95% 96.94% -0.01%
==========================================
Files 74 74
Lines 4003 3993 -10
==========================================
- Hits 3881 3871 -10
Misses 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
force-pushed
the
refactor-parse-datetime
branch
from
897803d to
5e9c0f5
Compare
lukasmetzner
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy to eventually swap
isoparsewithdatetime.fromisoformat(first attempt was reverted in #231).Related to https://docs.hetzner.cloud/changelog#2025-12-09-api-timestamp-format-rfc3339