feat: Absorb phonemizer.js and add all languages to the espeakng worker#262
Open
brianferri wants to merge 1 commit intohexgrad:mainfrom
Open
feat: Absorb phonemizer.js and add all languages to the espeakng worker#262brianferri wants to merge 1 commit intohexgrad:mainfrom
brianferri wants to merge 1 commit intohexgrad:mainfrom
Conversation
I got tired of waiting for more languages to be added to phonemizer.js so I just did it myself. The worker data and data chunks were re-compiled with all available ESpeakNG languages from the original espeakng repo and then patched in to the phonemizer.js base worker. Keeping it here will allow for better future maintainability as well. The licences between the projects are all the same so that should also be a non-issue. I've only added a test that was relevant for me and fixed up some of the english ones with the updated worker data, but all languages should be supported and available. I've also gone ahead and integrated the xenova/phonemizer.js#4 PR, hopefully this doesn't spring any controversy, but I'll gladly patch it away if asked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got tired of waiting for more languages to be added to phonemizer.js so I just did it myself. The worker data and data chunks were re-compiled with all available ESpeakNG languages from the original espeakng repo and then patched in to the phonemizer.js base worker. Keeping it here will allow for better future maintainability as well. The licences between the projects are all the same so that should also be a non-issue.
I've only added a test that was relevant for me and fixed up some of the english ones with the updated worker data, but all languages should be supported and available.
I've also gone ahead and integrated the
xenova/phonemizer.js#4 PR, hopefully this doesn't spring any controversy, but I'll gladly patch it away if asked.
closes #253