podliy16 solution#14
Open
podliy16 wants to merge 1 commit intohexlet-exercises:masterfrom
podliy16:master
Open
podliy16 solution#14podliy16 wants to merge 1 commit intohexlet-exercises:masterfrom podliy16:master
podliy16 wants to merge 1 commit intohexlet-exercises:masterfrom
podliy16:master
Conversation
Contributor
|
Цитирую readme: |
Author
|
Это вы про reduce? Он же внутри посимвольным перебором, или нужно самому явно это написать? И что тогда с реквестом делать? Закрывать и новый открывать или можно в этом изменить? |
Contributor
|
Нужно самому явно, мы же учимся, а не таски в проекте выполняем. Надо поправить и сделать git commit --amend (потому что я мержу пулреквесты состоящие только из одного коммита). Оно автоматом подменится в пулреквесте. |
podliy16 solution
Author
|
Поменял функциональный метод. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Функциональный подход не очень функциональный, но все равно.