fix/internal json pointer bundling #11
Merged
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling - Add shouldInlineInternal helper to determine when internal refs should be copied inline - Internal refs under #/paths/ are now dereferenced (copied) instead of left as - Components/schemas, definitions, and declarations still preserved as refs
This was referenced Aug 29, 2025
mrlubos
reviewed
Aug 29, 2025
lib/bundle.ts
Outdated
| if (!h || h === "#") { | ||
| return false; | ||
| } | ||
| if (h.startsWith("#/components/schemas") || h.indexOf("/definitions") !== -1 || h.startsWith("#/declarations")) { |
There was a problem hiding this comment.
Why do you
- use indexOf for definitions but startsWith for the rest?
- write it as
/definitionsand not#/definitions(with pound sign) like the rest - mention
#/declarations? Where do those come from? It's not an OpenAPI 2.0/3.0/3.1 concept as far as I know
There was a problem hiding this comment.
You're right, I mush have used some weird website to base it on lol
I cleaned it up
mrlubos
reviewed
Sep 1, 2025
lib/bundle.ts
Outdated
| if (!h || h === "#") { | ||
| return false; | ||
| } | ||
| if (h.startsWith("#/components/schemas") || h.startsWith("#/definitions")) { |
There was a problem hiding this comment.
I mean why even do these checks when all we care about is whether it starts with paths? This is all redundant no?
mrlubos
approved these changes
Sep 1, 2025
carson2222
changed the title
|
🎉 This PR is included in version 1.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.