test(client): add tests for zero-length response handling across various content types

Author: volesen

packages/openapi-ts/src/plugins/@hey-api/client-fetch/__tests__/client.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it } from 'vitest';
+import { describe, expect, it, vi } from 'vitest';
 
 import { createClient } from '../bundle/client';
 
@@ -68,3 +68,152 @@ describe('buildUrl', () => {
     expect(client.buildUrl(options)).toBe(url);
   });
 });
+
+describe('zero-length body handling', () => {
+  const client = createClient({ baseUrl: 'https://example.com' });
+
+  it('returns empty Blob for zero-length application/octet-stream response', async () => {
+    const mockResponse = new Response(null, {
+      headers: {
+        'Content-Length': '0',
+        'Content-Type': 'application/octet-stream',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      url: '/test',
+    });
+
+    expect(result.data).toBeInstanceOf(Blob);
+    expect((result.data as Blob).size).toBe(0);
+  });
+
+  it('returns empty ArrayBuffer for zero-length response with arrayBuffer parseAs', async () => {
+    const mockResponse = new Response(null, {
+      headers: {
+        'Content-Length': '0',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      parseAs: 'arrayBuffer',
+      url: '/test',
+    });
+
+    expect(result.data).toBeInstanceOf(ArrayBuffer);
+    expect((result.data as ArrayBuffer).byteLength).toBe(0);
+  });
+
+  it('returns empty string for zero-length text response', async () => {
+    const mockResponse = new Response(null, {
+      headers: {
+        'Content-Length': '0',
+        'Content-Type': 'text/plain',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      url: '/test',
+    });
+
+    expect(result.data).toBe('');
+  });
+
+  it('returns empty object for zero-length JSON response', async () => {
+    const mockResponse = new Response(null, {
+      headers: {
+        'Content-Length': '0',
+        'Content-Type': 'application/json',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      url: '/test',
+    });
+
+    expect(result.data).toEqual({});
+  });
+
+  it('returns empty FormData for zero-length multipart/form-data response', async () => {
+    const mockResponse = new Response(null, {
+      headers: {
+        'Content-Length': '0',
+        'Content-Type': 'multipart/form-data',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      url: '/test',
+    });
+
+    expect(result.data).toBeInstanceOf(FormData);
+    expect([...(result.data as FormData).entries()]).toHaveLength(0);
+  });
+
+  it('returns stream body for zero-length stream response', async () => {
+    const mockBody = new ReadableStream();
+    const mockResponse = new Response(mockBody, {
+      headers: {
+        'Content-Length': '0',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      parseAs: 'stream',
+      url: '/test',
+    });
+
+    expect(result.data).toBe(mockBody);
+  });
+
+  it('handles non-zero content correctly for comparison', async () => {
+    const blobContent = new Blob(['test data']);
+    const mockResponse = new Response(blobContent, {
+      headers: {
+        'Content-Type': 'application/octet-stream',
+      },
+      status: 200,
+    });
+
+    const mockFetch = vi.fn().mockResolvedValue(mockResponse);
+
+    const result = await client.request({
+      fetch: mockFetch,
+      method: 'GET',
+      url: '/test',
+    });
+
+    expect(result.data).toBeInstanceOf(Blob);
+    expect((result.data as Blob).size).toBeGreaterThan(0);
+  });
+});