Skip to content

feat: Refactor Angular client integration and enhance error handling #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

max-scopp
Copy link
Contributor

  • Updated openapi-ts.config.ts to configure Angular client plugin with error handling option.
  • Modified app.component.html to use a demo component for displaying pet information.
  • Refactored app.component.ts to remove direct API calls and integrate with the new demo component.
  • Enhanced app.config.ts to provide the Hey API client for dependency injection.
  • Improved error handling in client utilities and response processing.
  • Added new demo component with HTML and CSS for displaying pet information and error messages.
  • Updated client generation scripts to support new error handling and response structures.
  • Refactored HTTP client usage to support custom injectors and improved error response handling.

- Updated `openapi-ts.config.ts` to configure Angular client plugin with error handling option.
- Modified `app.component.html` to use a demo component for displaying pet information.
- Refactored `app.component.ts` to remove direct API calls and integrate with the new demo component.
- Enhanced `app.config.ts` to provide the Hey API client for dependency injection.
- Improved error handling in client utilities and response processing.
- Added new demo component with HTML and CSS for displaying pet information and error messages.
- Updated client generation scripts to support new error handling and response structures.
- Refactored HTTP client usage to support custom injectors and improved error response handling.
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Aug 11, 2025

⚠️ No Changeset found

Latest commit: 2996bde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 11, 2025

@max-scopp is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. client Client package related feature 🚀 New feature or request labels Aug 11, 2025
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 23.07692% with 50 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@275f403). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/plugins/@hey-api/client-angular/bundle/client.ts 2.63% 37 Missing ⚠️
...rc/plugins/@hey-api/client-angular/bundle/utils.ts 51.85% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2422   +/-   ##
=======================================
  Coverage        ?   22.75%           
=======================================
  Files           ?      334           
  Lines           ?    32972           
  Branches        ?     1302           
=======================================
  Hits            ?     7503           
  Misses          ?    25460           
  Partials        ?        9           
Flag Coverage Δ
unittests 22.75% <23.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 11, 2025
This was referenced Aug 11, 2025
@max-scopp
Copy link
Contributor Author

Closed in favour in pipeline fixes already done in #2423

@max-scopp max-scopp closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client package related feature 🚀 New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant