Unexpected behaviour of validate() in BinaryField, DecimalField and UrlField#130
Open
steven266 wants to merge 4 commits intoheynemann:masterfrom
Open
Unexpected behaviour of validate() in BinaryField, DecimalField and UrlField#130steven266 wants to merge 4 commits intoheynemann:masterfrom
steven266 wants to merge 4 commits intoheynemann:masterfrom
Conversation
…ed is False and value is None
…ed is False and value is None
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I recently started using MotorEngine and quickly came up with a strange behaviour of the validate function in certain Fields. If required is
Falsethen validate should allowNoneas a valid value.I added a fix for BinaryField, DecimalField and UrlField and would be glad if this fix could be merged back into the original project.
Best regards,
Steven