-
-
Notifications
You must be signed in to change notification settings - Fork 7
Update Kotlin to 2.3.0 and Compose to 1.9.3 #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps `kotlin` from 2.2.21 to 2.3.0. Updates `org.jetbrains.kotlin.js` from 2.2.21 to 2.3.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.3.0) Updates `org.jetbrains.kotlin.plugin.serialization` from 2.2.21 to 2.3.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.3.0) Updates `org.jetbrains.kotlin.plugin.compose` from 2.2.21 to 2.3.0 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.2.21...v2.3.0) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.js dependency-version: 2.3.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-version: 2.3.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin.plugin.compose dependency-version: 2.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps `compose` from 1.9.0 to 1.9.3. Updates `org.jetbrains.compose.runtime:runtime` from 1.9.0 to 1.9.3 - [Release notes](https://github.com/JetBrains/compose-jb/releases) - [Changelog](https://github.com/JetBrains/compose-multiplatform/blob/master/CHANGELOG.md) - [Commits](JetBrains/compose-multiplatform@v1.9.0...v1.9.3) Updates `org.jetbrains.compose.html:html-core` from 1.9.0 to 1.9.3 - [Release notes](https://github.com/JetBrains/compose-jb/releases) - [Changelog](https://github.com/JetBrains/compose-multiplatform/blob/master/CHANGELOG.md) - [Commits](JetBrains/compose-multiplatform@v1.9.0...v1.9.3) Updates `org.jetbrains.compose.html:html-svg` from 1.9.0 to 1.9.3 - [Release notes](https://github.com/JetBrains/compose-jb/releases) - [Changelog](https://github.com/JetBrains/compose-multiplatform/blob/master/CHANGELOG.md) - [Commits](JetBrains/compose-multiplatform@v1.9.0...v1.9.3) Updates `org.jetbrains.compose.html:html-test-utils` from 1.9.0 to 1.9.3 - [Release notes](https://github.com/JetBrains/compose-jb/releases) - [Changelog](https://github.com/JetBrains/compose-multiplatform/blob/master/CHANGELOG.md) - [Commits](JetBrains/compose-multiplatform@v1.9.0...v1.9.3) --- updated-dependencies: - dependency-name: org.jetbrains.compose.runtime:runtime dependency-version: 1.9.3 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.compose.html:html-core dependency-version: 1.9.3 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.compose.html:html-svg dependency-version: 1.9.3 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.compose.html:html-test-utils dependency-version: 1.9.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the project's Kotlin and Compose dependencies to versions 2.3.0 and 1.9.3 respectively, and removes implicit CSS handling throughout the codebase. The changes include removing automatic SCSS imports via Style references, restructuring webpack configuration for SCSS support, updating Gradle wrapper to 9.2.1, and modernizing signing and plugin management configurations.
Key changes:
- Upgraded Kotlin from 2.2.21 to 2.3.0 and Compose from 1.9.0 to 1.9.3
- Removed implicit CSS loading by deleting the
scss.ktfile and allStylereferences - Migrated SCSS support configuration from
setup.gradle.ktstoshowcase/build.gradle.kts
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated Kotlin to 2.3.0, Compose to 1.9.3, and added foojay and sigstore plugin entries |
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle wrapper from 9.2.0-rc-1 to 9.2.1 |
| settings.gradle.dcl | Removed foojay-resolver-convention plugin declaration |
| gradle/build-logic/src/main/kotlin/MyRepos.settings.gradle.kts | Added foojay-resolver-convention plugin |
| gradle/build-logic/src/main/kotlin/setup.gradle.kts | Removed SCSS support configuration and simplified browser setup |
| showcase/build.gradle.kts | Added SCSS support configuration via commonWebpackConfig |
| gradle/build-logic/src/main/kotlin/publishedLibrary.gradle.kts | Added sigstore plugin and modernized signing configuration |
| gradle/build-logic/settings.gradle.kts | Added gradlePluginPortal to repositories |
| gradle/build-logic/build.gradle.kts | Added sigstore and foojay plugin dependencies |
| bootstrap-compose/src/jsMain/kotlin/app/softwork/bootstrapcompose/scss.kt | Deleted file containing implicit CSS import |
| bootstrap-compose/src/jsMain/kotlin/app/softwork/bootstrapcompose/*.kt | Removed Style reference calls from 27 component files |
| showcase/src/jsMain/kotlin/app/softwork/bootstrapcompose/showcase/InputGroupView.kt | Removed redundant null-safety operator |
| .github/workflows/dependencies.yml | Changed runner to ubuntu-slim and added explicit permissions |
| .github/workflows/CD.yml | Added explicit permissions for contents and id-token |
Files not reviewed (1)
- kotlin-js-store/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- kotlin-js-store/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.