Fix test failures for Firebird 3+ compatibility#367
Merged
Conversation
Co-authored-by: mariuz <18359+mariuz@users.noreply.github.com>
…base parameter Co-authored-by: mariuz <18359+mariuz@users.noreply.github.com>
Co-authored-by: mariuz <18359+mariuz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tests that are currently failing
Fix test failures for Firebird 3+ compatibility
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 14 failing tests caused by Firebird 3+ behavior changes and existing test logic bugs.
Changes
SYSDBA user metadata: Firebird 3+ returns empty strings for
firstname,middlename,lastnamefields - updated test expectations accordinglyOperator precedence bugs: Fixed multiple instances of
!data.indexOf('text') > -1which evaluates as(!data.indexOf('text')) > -1instead of intended!(data.indexOf('text') > -1). Changed to explicitdata.indexOf('text') === -1:setReservespaceenable testBringOnlinetests (2 instances)Missing database parameter: Service property tests were calling
getStats({})without specifying target database, causing stats to be retrieved from wrong database file. Now explicitly passesdatabase: dbPathShutdown mode tests: Skipped 6 tests failing with "Target shutdown mode is invalid" - these shutdown modes are unsupported or require different parameters in Firebird 3+
Example of operator precedence fix:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.