Fixes #2274: Numpy-specific to_compact()#2275
Open
sieben-gea wants to merge 1 commit intohgrecco:masterfrom
Open
Fixes #2274: Numpy-specific to_compact()#2275sieben-gea wants to merge 1 commit intohgrecco:masterfrom
sieben-gea wants to merge 1 commit intohgrecco:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_compact()fails with numpy quantities #2274pre-commit run --all-filesorpixi run lint --all-fileswith no errorsI modified
qto.to_compact()to work with numpy magnitudes and added that toNumpyQuantity. The SI prefix list generation could maybe also be moved into a different function, because it is unchanged between the two implementations. Let me know what you think!