Skip to content

feat(language): lower hgraph IR bodies - #693

Merged
hhenson merged 2 commits into
codex/hgl-hgraph-ir-contractsfrom
codex/hgl-hgraph-ir-bodies
Sep 6, 2026
Merged

feat(language): lower hgraph IR bodies#693
hhenson merged 2 commits into
codex/hgl-hgraph-ir-contractsfrom
codex/hgl-hgraph-ir-bodies

Conversation

@hhenson

@hhenson hhenson commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • lower typed callable and test bodies into independently owned hgraph-IR arenas
  • preserve stable bindings, exact and nominal operations, substitutions, state, lifecycle, activation, traversal, assignments, and test plans
  • prevent block-tail expressions from also appearing as executable statements
  • extend the deterministic source-ranged dump, architecture documentation, roadmap, and focused coverage

Validation

  • clang-format on changed C++ files
  • git diff --check
  • focused hgraph-IR suite: 262 assertions in 14 test cases
  • complete language CTest suite: 29/29 passed
  • clean native configure, rebuild, and CTest suite: 1711/1711 passed
  • stable-ABI wheel built with Python 3.12 and complete non-WIP compatibility suite run from a fresh Python 3.14 environment: 3223 passed, 10 skipped

Stacked on #691.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T15:46:10.750937Z 4d288af PR opened
🔒 Security Review Completed 2026-09-05T15:44:32.671682Z 4d288af PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d288afe01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread language/src/hgraph_ir/printer.cpp
@hhenson
hhenson force-pushed the codex/hgl-hgraph-ir-bodies branch from ee97045 to ef91219 Compare September 5, 2026 16:29
@hhenson
hhenson force-pushed the codex/hgl-hgraph-ir-bodies branch 2 times, most recently from 04ab6a5 to 919a4c2 Compare September 5, 2026 18:20
@hhenson
hhenson force-pushed the codex/hgl-hgraph-ir-bodies branch from 919a4c2 to e2c58ba Compare September 5, 2026 19:56
@hhenson
hhenson force-pushed the codex/hgl-hgraph-ir-bodies branch from e2c58ba to b1a5c68 Compare September 6, 2026 05:34
@sonarqubecloud

sonarqubecloud Bot commented Sep 6, 2026

Copy link
Copy Markdown

@hhenson
hhenson merged commit ad13d74 into main Sep 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant