Skip to content

Preserve operator provider provenance in HGL IR - #714

Merged
hhenson merged 2 commits into
codex/hgl-codegen-architecture-guardfrom
codex/hgl-operator-provider-provenance
Sep 6, 2026
Merged

Preserve operator provider provenance in HGL IR#714
hhenson merged 2 commits into
codex/hgl-codegen-architecture-guardfrom
codex/hgl-operator-provider-provenance

Conversation

@hhenson

@hhenson hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • expose the selected keyed installer through a source-compatible, shared-library-exported ResolvedOperatorCall::provider_key() accessor
  • copy provider identity through native operator selection, typed HIR, and HGraph IR without retaining registry pointers or leases
  • document the provenance boundary and keep concrete provider-requirement planning as the next slice

Validation

  • 1,716/1,716 fresh native C++ tests
  • stable-ABI wheel built with Python 3.12; 3,240 passed and 10 skipped on Python 3.14
  • 32/32 HGL integration tests
  • focused provider lifecycle and operator/HGraph IR tests

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T05:49:40.250783Z 6d07817 Manual request
🔒 Security Review Completed 2026-09-06T05:50:40.170823Z 6d07817 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hhenson

hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@hhenson

hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 82891b15a9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82891b15a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread include/hgraph/types/operator_dispatch.h Outdated
Comment thread language/CMakeLists.txt
@hhenson
hhenson force-pushed the codex/hgl-operator-provider-provenance branch from 82891b1 to e5fd9ef Compare September 6, 2026 05:42
@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 82891b15a9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@sonarqubecloud

sonarqubecloud Bot commented Sep 6, 2026

Copy link
Copy Markdown

@hhenson

hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@hhenson

hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 6d0781784d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6d0781784d

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@hhenson
hhenson merged commit ad13d74 into main Sep 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant