Skip to content

Language: describe canonical module interfaces - #721

Open
hhenson wants to merge 2 commits into
codex/hgl-native-module-descriptorfrom
codex/hgl-descriptor-interface-schema
Open

Language: describe canonical module interfaces#721
hhenson wants to merge 2 commits into
codex/hgl-native-module-descriptorfrom
codex/hgl-descriptor-interface-schema

Conversation

@hhenson

@hhenson hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • emit structured public and provider signatures, struct layouts, defaults, canonical types, and generic constraints in HGL module descriptors
  • preserve stable declaration-scoped bindings and deterministic descriptor-local schema references
  • split canonical JSON serialization from HGraph IR snapshot construction and encode i64/f64 literal payloads without narrowing or invalid JSON
  • document the implemented interface boundary and the remaining descriptor reader, dependency, lifecycle, ownership/effect, and fingerprint work

Validation

  • ctest --test-dir cmake-build-hgl-lexy --parallel 2 --output-on-failure (1,749/1,749)
  • cmake --preset cpp --fresh
  • cmake --build --preset cpp --target clean
  • cmake --build --preset cpp --parallel
  • ctest --preset cpp --parallel 2 (1,716/1,716)
  • Python 3.12 ABI3 wheel installed under Python 3.14; pytest python/tests -q -m "not wip" (3,241 passed, 10 skipped)
  • .venv/bin/sphinx-build -W --keep-going -b html docs/source <temp>
  • clang-format check and git diff --check
  • all eight HGL example/codegen inputs emitted descriptors accepted by python3 -m json.tool

Stacked on #719.

@hhenson

hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@hhenson

hhenson commented Sep 6, 2026

Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T07:16:52.517100Z 6790f6c Manual request
🔒 Security Review Completed 2026-09-06T07:16:45.541196Z 6790f6c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6790f6c5cb

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6790f6c5cb

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 6790f6c5cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hhenson
hhenson force-pushed the codex/hgl-descriptor-interface-schema branch from 6790f6c to 843a9dd Compare September 6, 2026 07:34
@sonarqubecloud

sonarqubecloud Bot commented Sep 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant