Skip to content

introduce parallel diff #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhiroshell merged 1 commit into from
Jan 6, 2025
Merged

introduce parallel diff #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/cmd/realname-diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ func NewCmdRealnameDiff(streams genericclioptions.IOStreams) *cobra.Command {
configFlags.AddFlags(cmd.Flags())
cmd.Flags().StringVarP(&options.selector, "selector", "l", options.selector, "Selector (label query) to filter on, supports '=', '==', and '!='.(e.g. -l key1=value1,key2=value2)")
cmd.Flags().BoolVar(&options.showManagedFields, "show-managed-fields", options.showManagedFields, "If true, include managed fields in the diff.")
cmd.Flags().IntVar(&options.concurrency, "concurrency", 1, "Number of objects to process in parallel when diffing against the live version. Larger number = faster, but more memory, I/O and CPU over that shorter period of time.")
cmdutil.AddFilenameOptionFlags(cmd, &options.filenameOptions, "Contains the configuration to diff")
cmdutil.AddServerSideApplyFlags(cmd)
cmdutil.AddFieldManagerFlagVar(cmd, &options.fieldManager, apply.FieldManagerClientSideApply)
Expand Down Expand Up @@ -116,6 +117,7 @@ type RealnameDiffOptions struct {
forceConflicts bool
showManagedFields bool

concurrency int
selector string
openAPIGetter openapi.OpenAPIResourcesGetter
openAPIV3Root openapi3.Root
Expand Down Expand Up @@ -328,6 +330,7 @@ func (o *RealnameDiffOptions) Run() error {

r := o.builder.
Unstructured().
VisitorConcurrency(o.concurrency).
NamespaceParam(o.cmdNamespace).DefaultNamespace().
FilenameParam(o.enforceNamespace, &o.filenameOptions).
LabelSelectorParam(o.selector).
Expand Down
Loading