Skip to content

Bump the quarkus group with 3 updates #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2024
+15 −5
Merged

Bump the quarkus group with 3 updates #286

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9d6ca6
Bump the quarkus group with 3 updates
dependabot[bot] Nov 11, 2024
fdcf8d4
Ignore LTS versions for OpenApi generator
marko-bekhta Nov 11, 2024
fe4c5cc
Add a dependency on quarkus-rest-client-oidc-filter to make OpenApi g…
marko-bekhta Nov 11, 2024
c966e99
Use the same config key as spec id
marko-bekhta Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@ updates:
# Releases too often, it's annoying
- dependency-name: "org.assertj:*"
update-types: ["version-update:semver-patch"]

# We don't want to stay on an LTS version and want to have more regular updates here:
- dependency-name: "io.quarkiverse.openapi.generator:*"
versions: ["2.6.0-lts"]
10 changes: 9 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<quarkus-github-app.version>2.7.0</quarkus-github-app.version>
<quarkus-openapi-generator.version>2.6.0-lts</quarkus-openapi-generator.version>
<quarkus-openapi-generator.version>2.6.0</quarkus-openapi-generator.version>
<!-- Using a single property for both plugin and platform, so that GitHub's Dependabot doesn't get confused -->
<quarkus.version>3.16.2</quarkus.version>
<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
Expand Down Expand Up @@ -100,6 +100,14 @@
<artifactId>quarkus-openapi-generator</artifactId>
<version>${quarkus-openapi-generator.version}</version>
</dependency>
<!--
Without the OIDC filter dependency generated client leads to an obscure errors like:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this already reported? If so we may want to add a link here?

> WARN [io.qua.arc.pro.BeanArchives] Failed to index io.quarkus.oidc.client.runtime.AbstractTokensProducer: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: TEST for DevelocityReportFormatterTest (QuarkusTest)@65b19e5c
-->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-rest-client-oidc-filter</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-rest-client-jackson</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ quarkus.cache.caffeine."glob-cache".maximum-size=200
hibernate-github-bot.jenkins.github-app-id=347853
hibernate-github-bot.develocity.uri=https://ge.hibernate.org/

quarkus.openapi-generator.codegen.spec.gradle_enterprise_2023_4_api_yaml.config-key=develocity
quarkus.openapi-generator.codegen.spec.gradle_enterprise_2023_4_api_yaml.config-key=gradle_enterprise_2023_4_api_yaml
Copy link
Member

@yrodiere yrodiere Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this line was to use a simpler key 🙂 I take it it no longer works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah 😖 I've opened this PR quarkiverse/quarkus-openapi-generator#848 it should allow to use keys again

quarkus.openapi-generator.codegen.spec.gradle_enterprise_2023_4_api_yaml.base-package=com.gradle.develocity
quarkus.rest-client.develocity.uri=${hibernate-github-bot.develocity.uri}
quarkus.rest-client."gradle_enterprise_2023_4_api_yaml".uri=${hibernate-github-bot.develocity.uri}
quarkus.openapi-generator.gradle_enterprise_2023_4_api_yaml.auth.DevelocityAccessKey.bearer-token=${hibernate-github-bot.develocity.access-key}

%dev.quarkus.rest-client.logging.scope=request-response
Expand Down