Skip to content

Explicitly install OC as one of the build steps #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marko-bekhta
Copy link
Member

Error: Error: Unable to locate executable file: oc. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

https://github.com/hibernate/hibernate-github-bot/actions/runs/12347663679/job/34466352632

oc should've been installed by default according to the https://github.com/redhat-actions/oc-login/blob/dfbd9912672664f9df2023c1c16e07bcf306043c/README.md#getting-started

but the build complains about it 😖

looking at the logs of this failing deploy-build:

Operating System
  Ubuntu
  24.04.1
  LTS

and in the others e.g. for search.quarkus.io:

Operating System
  Ubuntu
  22.04.5
  LTS

Both request a ubuntu-latest... according to https://github.com/actions/runner-images/blob/5c8a14c94ce4ce691feb225859daa030c5ff896f/README.md it should've been a 22...

Do we report this to the runner-images or .... (since oc should be available by default on these...)

@yrodiere
Copy link
Member

Do we report this to the runner-images or .... (since oc should be available by default on these...)

The lack of oc in Ubuntu 24 appears to be on purpose; official documentation from GitHub lists oc on Ubuntu 22 but not on Ubuntu 24:

I suppose you can try to find the reason for this change, or look for already reported issues, but I doubt this will lead anywhere.

The fact 24 was used instead of 22 for ubuntu-latest might be due to a rollout in progress? Still, similarly if you can't find any announcement about that, it's worth reporting.

In any case, I think this change is worth merging: it'll shield us from this problem ever happening again, and will ensure we're using the latest version of oc.

Comment on lines 47 to 48
# "mirror" is the default source, so this is optional.
source: "mirror"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# "mirror" is the default source, so this is optional.
source: "mirror"

@marko-bekhta marko-bekhta force-pushed the build/install-oc-explicitly branch from 61ea293 to 3ff9527 Compare December 16, 2024 15:21
@marko-bekhta marko-bekhta marked this pull request as ready for review December 16, 2024 15:21
@marko-bekhta
Copy link
Member Author

OpenShift CLI latest available - Removed from the Ubuntu 24.04 image due to maintenance reasons.

actions/runner-images#10636

No need to open a ticket, I suppose 😄
I'll add this update to other repositories where we use oc login

@marko-bekhta marko-bekhta merged commit 8d30b14 into hibernate:main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants