Skip to content

Commit a23f60d

Browse files
committed
fix verbosity of logging in BootstrapContextImpl and ClassLoaderAccessImpl
1 parent 9551111 commit a23f60d

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

hibernate-core/src/main/java/org/hibernate/boot/internal/BootstrapContextImpl.java

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -307,28 +307,43 @@ public void addAttributeConverterDescriptor(ConverterDescriptor<?,?> descriptor)
307307
}
308308
}
309309

310-
void injectJpaTempClassLoader(ClassLoader jpaTempClassLoader) {
311-
log.tracef( "Injecting JPA temp ClassLoader [%s] into BootstrapContext; was [%s]", jpaTempClassLoader, this.getJpaTempClassLoader() );
312-
this.classLoaderAccess.injectTempClassLoader( jpaTempClassLoader );
310+
void injectJpaTempClassLoader(ClassLoader classLoader) {
311+
if ( log.isTraceEnabled() && classLoader != getJpaTempClassLoader() ) {
312+
log.tracef( "Injecting JPA temp ClassLoader [%s] into BootstrapContext; was [%s]",
313+
classLoader, getJpaTempClassLoader() );
314+
}
315+
this.classLoaderAccess.injectTempClassLoader( classLoader );
313316
}
314317

315318
void injectScanOptions(ScanOptions scanOptions) {
316-
log.tracef( "Injecting ScanOptions [%s] into BootstrapContext; was [%s]", scanOptions, this.scanOptions );
319+
if ( log.isTraceEnabled() && scanOptions != this.scanOptions ) {
320+
log.tracef( "Injecting ScanOptions [%s] into BootstrapContext; was [%s]",
321+
scanOptions, this.scanOptions );
322+
}
317323
this.scanOptions = scanOptions;
318324
}
319325

320326
void injectScanEnvironment(ScanEnvironment scanEnvironment) {
321-
log.tracef( "Injecting ScanEnvironment [%s] into BootstrapContext; was [%s]", scanEnvironment, this.scanEnvironment );
327+
if ( log.isTraceEnabled() && scanEnvironment != this.scanEnvironment ) {
328+
log.tracef( "Injecting ScanEnvironment [%s] into BootstrapContext; was [%s]",
329+
scanEnvironment, this.scanEnvironment );
330+
}
322331
this.scanEnvironment = scanEnvironment;
323332
}
324333

325334
void injectScanner(Scanner scanner) {
326-
log.tracef( "Injecting Scanner [%s] into BootstrapContext; was [%s]", scanner, this.scannerSetting );
335+
if ( log.isTraceEnabled() && scanner != this.scannerSetting ) {
336+
log.tracef( "Injecting Scanner [%s] into BootstrapContext; was [%s]",
337+
scanner, scannerSetting );
338+
}
327339
this.scannerSetting = scanner;
328340
}
329341

330342
void injectArchiveDescriptorFactory(ArchiveDescriptorFactory factory) {
331-
log.tracef( "Injecting ArchiveDescriptorFactory [%s] into BootstrapContext; was [%s]", factory, this.archiveDescriptorFactory );
343+
if ( log.isTraceEnabled() && factory != archiveDescriptorFactory ) {
344+
log.tracef( "Injecting ArchiveDescriptorFactory [%s] into BootstrapContext; was [%s]",
345+
factory, archiveDescriptorFactory );
346+
}
332347
this.archiveDescriptorFactory = factory;
333348
}
334349

hibernate-core/src/main/java/org/hibernate/boot/internal/ClassLoaderAccessImpl.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,20 +54,19 @@ public Class<?> classForName(String name) {
5454
return classLoaderService.classForName( name );
5555
}
5656
else {
57-
log.tracef( "Not known whether passed class name [%s] is safe", name );
57+
// Could not determine that the given class is safe to load with live ClassLoader
5858
if ( jpaTempClassLoader == null ) {
5959
log.tracef(
60-
"No temp ClassLoader provided; using live ClassLoader " +
61-
"for loading potentially unsafe class: %s",
60+
"No temp ClassLoader provided; using live ClassLoader to load potentially unsafe class: %s",
6261
name
6362
);
6463
return classLoaderService.classForName( name );
6564
}
6665
else {
67-
log.tracef(
68-
"Temp ClassLoader was provided, so we will use that: %s",
69-
name
70-
);
66+
// log.tracef(
67+
// "Temp ClassLoader was provided, so we will use that: %s",
68+
// name
69+
// );
7170
try {
7271
return jpaTempClassLoader.loadClass( name );
7372
}

0 commit comments

Comments
 (0)