extract a tiny method

Author: gavinking

hibernate-core/src/main/java/org/hibernate/persister/collection/AbstractCollectionPersister.java

@@ -910,9 +910,7 @@ public boolean isArray() {
 
 	@Override
 	public String getIdentifierColumnName() {
-		return collectionSemantics.getCollectionClassification() == CollectionClassification.ID_BAG
-				? identifierColumnName
-				: null;
+		return hasId() ? identifierColumnName : null;
 	}
 
 	/**
@@ -975,7 +973,7 @@ public String selectFragment(String alias, String columnSuffix) {
 				i++;
 			}
 		}
-		if ( collectionSemantics.getCollectionClassification() == CollectionClassification.ID_BAG ) {
+		if ( hasId() ) {
 			sqlSelections.set(
 					i,
 					new SqlSelectionImpl(
@@ -1063,6 +1061,10 @@ public boolean hasIndex() {
 		return collectionSemantics.getCollectionClassification().isIndexed();
 	}
 
+	private boolean hasId() {
+		return collectionSemantics.getCollectionClassification() == CollectionClassification.ID_BAG;
+	}
+
 	@Override
 	public boolean isLazy() {
 		return isLazy;
@@ -1394,7 +1396,7 @@ public void initCollectionPropertyMap() {
 		if ( hasIndex() ) {
 			initCollectionPropertyMap( "index", indexType, indexColumnAliases );
 		}
-		if ( collectionSemantics.getCollectionClassification() == CollectionClassification.ID_BAG ) {
+		if ( hasId() ) {
 			initCollectionPropertyMap( "id", identifierType, new String[] { identifierColumnAlias } );
 		}
 	}
@@ -1856,21 +1858,11 @@ public String[] getElementColumnAliases(String suffix) {
 
 	@Override
 	public String[] getIndexColumnAliases(String suffix) {
-		if ( hasIndex() ) {
-			return new Alias( suffix ).toAliasStrings( indexColumnAliases );
-		}
-		else {
-			return null;
-		}
+		return hasIndex() ? new Alias( suffix ).toAliasStrings( indexColumnAliases ) : null;
 	}
 
 	@Override
 	public String getIdentifierColumnAlias(String suffix) {
-		if ( collectionSemantics.getCollectionClassification() == CollectionClassification.ID_BAG ) {
-			return new Alias( suffix ).toAliasString( identifierColumnAlias );
-		}
-		else {
-			return null;
-		}
+		return hasId() ? new Alias( suffix ).toAliasString( identifierColumnAlias ) : null;
 	}
 }