HHH-19260 - Remove supportsNullPrecedence() from AbstractSqlAstTranslator (was already in Dialect)

Signed-off-by: Jan Schatteman <[email protected]>

Author: jrenaat

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java

@@ -1078,4 +1078,10 @@ public boolean supportsJoinInMutationStatementSubquery() {
 		return false;
 	}
 
+	@Override
+	public boolean supportsNullPrecedence() {
+		// Support for nulls clause in listagg was added in 2.0
+		return getVersion().isSameOrAfter( 2 );
+	}
+
 }

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacySqlAstTranslator.java

@@ -370,10 +370,8 @@ protected boolean supportsRowValueConstructorDistinctFromSyntax() {
 		return getDialect().getVersion().isSameOrAfter( 1, 4, 200 );
 	}
 
-	@Override
-	protected boolean supportsNullPrecedence() {
-		// Support for nulls clause in listagg was added in 2.0
-		return getClauseStack().getCurrent() != Clause.WITHIN_GROUP || getDialect().getVersion().isSameOrAfter( 2 );
+	protected boolean allowsNullPrecedence() {
+		return getClauseStack().getCurrent() != Clause.WITHIN_GROUP || getDialect().supportsNullPrecedence();
 	}
 
 	private boolean supportsOffsetFetchClause() {

hibernate-core/src/main/java/org/hibernate/dialect/H2SqlAstTranslator.java

@@ -342,12 +342,6 @@ protected boolean supportsRowValueConstructorDistinctFromSyntax() {
 		return true;
 	}
 
-	@Override
-	protected boolean supportsNullPrecedence() {
-		// Support for nulls clause in listagg was added in 2.0
-		return true;
-	}
-
 	private boolean supportsOffsetFetchClause() {
 		return true;
 	}

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -4324,7 +4324,7 @@ protected void visitSortSpecification(
 		}
 		final boolean renderNullPrecedence = nullPrecedence != null
 				&& !NullPrecedenceHelper.isDefaultOrdering( nullPrecedence, sortOrder, dialect.getNullOrdering() );
-		final boolean supportsNullPrecedence = renderNullPrecedence && supportsNullPrecedence();
+		final boolean supportsNullPrecedence = renderNullPrecedence && dialect.supportsNullPrecedence();
 		if ( renderNullPrecedence && !supportsNullPrecedence ) {
 			emulateSortSpecificationNullPrecedence( sortExpression, nullPrecedence );
 		}
@@ -4362,10 +4362,6 @@ protected void renderSortExpression(Expression sortExpression, boolean ignoreCas
 		}
 	}
 
-	protected boolean supportsNullPrecedence() {
-		return dialect.supportsNullPrecedence();
-	}
-
 	protected void emulateSortSpecificationNullPrecedence(Expression sortExpression, Nulls nullPrecedence) {
 		// TODO: generate "virtual" select items and use them here positionally
 		appendSql( "case when (" );