Skip to content

MutationSpecificationImpl#getResultType must return null (and not Void.class) #10083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

MutationSpecificationImpl#getResultType must return null (and not Void.class) #10083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16b153
HHH-19386 MutationSpecificationImpl#getResultType must return null
DavideD Apr 25, 2025
b287863
HHH-19386 Add test case
DavideD Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e/src/main/java/org/hibernate/query/specification/internal/MutationSpecificationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public String getName() {

@Override
public Class<Void> getResultType() {
return Void.class;
return null;
}

@Override
Expand Down
16 changes: 16 additions & 0 deletions ...ore/src/test/java/org/hibernate/orm/test/query/dynamic/SimpleQuerySpecificationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,22 @@ void testSimpleMutationRestriction(SessionFactoryScope factoryScope) {
assertThat( sqlCollector.getSqlQueries().get( 0 ) ).contains( " where be1_0.position between ? and ?" );
}

@Test
void testSimpleMutationRestrictionAsReference(SessionFactoryScope factoryScope) {
final SQLStatementInspector sqlCollector = factoryScope.getCollectingStatementInspector();
var deleteBasicEntity = MutationSpecification
.create( BasicEntity.class, "delete BasicEntity" )
.restrict( Restriction.restrict( BasicEntity_.position, Range.closed( 1, 5 ) ) )
.reference();
factoryScope.inTransaction( session -> {
sqlCollector.clear();
session.createQuery( deleteBasicEntity ).executeUpdate();
} );

assertThat( sqlCollector.getSqlQueries() ).hasSize( 1 );
assertThat( sqlCollector.getSqlQueries().get( 0 ) ).contains( " where be1_0.position between ? and ?" );
}

@Test
void testRootEntityForm(SessionFactoryScope factoryScope) {
final SQLStatementInspector sqlCollector = factoryScope.getCollectingStatementInspector();
Expand Down